Skip to content

Resolved Issue of Cardinality in WebVOWL#187

Merged
vitalis-wiens merged 2 commits intoVisualDataWeb:masterfrom
nandikajain:bugFixes_177
May 11, 2022
Merged

Resolved Issue of Cardinality in WebVOWL#187
vitalis-wiens merged 2 commits intoVisualDataWeb:masterfrom
nandikajain:bugFixes_177

Conversation

@nandikajain
Copy link
Copy Markdown
Contributor

@nandikajain nandikajain commented May 9, 2022 •
edited
Loading

Fixes #177 #155

As pointed out on the issue thread,

when only maxCardinality is defined (and minCardinality isn't specified), we should set the minimum cardinality as 0 and reflect the same in generateCardinalityText().

Screenshots:
Before
before
After
after

@nandikajain
Copy link
Copy Markdown
Contributor Author

nandikajain commented May 9, 2022 •
edited
Loading

@vitalis-wiens @steffen-l Also, the readme did not state how to run WebVOWL locally, so I have updated the README for the same as well.

This was referenced May 9, 2022
Open
Open
vitalis-wiens
vitalis-wiens approved these changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@vitalis-wiens vitalis-wiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

thanks :)

@vitalis-wiens vitalis-wiens merged commit 3d3dcc1 into VisualDataWeb:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitalis-wiens vitalis-wiens vitalis-wiens approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cardinality of min 0, max 1 is represented in WebVOWL as *..1 instead of 0..1 as documented

2 participants

@nandikajain @vitalis-wiens