Skip to content

Conversation

@tonoizer
Copy link
Contributor

@tonoizer tonoizer commented Apr 27, 2023

PR description

Describe your changes in detail here

Now you can regenerate a cryptographic token or you are able to create your own token by writing in the text field.
Currently, the rules are very simple, they have to be specified by the team in a more consice way. Additionally, I set it up so that the notification system is incorporated in this.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is NOT assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR

Fix: #118

@tonoizer
Copy link
Contributor Author

tonoizer commented Apr 27, 2023

The current rules for the token are just placeholders because I am unsure what the rules should be therefore we need to decide what is important

  1. min characters
  2. what characters have to be in
  3. numbers ?
  4. etc.

@Claiyc
Copy link
Member

Claiyc commented Apr 28, 2023

The current rules for the token are just placeholders because I am unsure what the rules should be therefore we need to decide what is important

1. min characters

2. what characters have to be in

3. numbers ?

4. etc.

see #118 reply

@tonoizer
Copy link
Contributor Author

I ran into something very strange but i don't know why

with this updated function so every generated token has all the properties
image

I reach the maximum call stack size

image

Copy link
Member

@Claiyc Claiyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session stopped message should not appear when session is not running

Copy link
Member

@Claiyc Claiyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tonoizer tonoizer merged commit 5320bac into main May 3, 2023
@tonoizer tonoizer deleted the feat/118-session-token branch May 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session Token

3 participants