Skip to content

fix: rename --runtemplate_id to --id on credential commands for consistency#34

Merged
Vitexus merged 1 commit into
mainfrom
fix/credential-command-id-option
May 28, 2026
Merged

fix: rename --runtemplate_id to --id on credential commands for consistency#34
Vitexus merged 1 commit into
mainfrom
fix/credential-command-id-option

Conversation

@Vitexus
Copy link
Copy Markdown
Member

@Vitexus Vitexus commented May 28, 2026

Summary

  • run-template:assign-credential, run-template:unassign-credential, and run-template:list-credentials were using --runtemplate_id as the RunTemplate ID option
  • All other run-template:* commands use --id — this was an inconsistency introduced in 2.5.4
  • Renamed the option to --id across all three commands, updated tests and documentation, bumped version to 2.5.5

Test plan

  • phpunit tests/src/Command/RunTemplateTest.php passes (16/16 assertions)
  • multiflexi-cli run-template:list-credentials --id 186 --format json works
  • multiflexi-cli run-template:assign-credential --id 186 --credential_id 12 works
  • multiflexi-cli run-template:unassign-credential --id 186 --credential_id 12 works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • The run-template:assign-credential, run-template:unassign-credential, and run-template:list-credentials commands now use --id instead of --runtemplate_id for specifying the RunTemplate ID parameter.
  • Documentation

    • Updated documentation with examples for run-template credential management operations, including listing, assigning, and unassigning credentials.

Review Change Stack

…stency

All run-template:* commands use --id for the RunTemplate ID; the three
credential commands introduced in 2.5.4 used --runtemplate_id instead.
Rename the option, update tests, docs, and bump version to 2.5.5.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ed6d7054-ae66-4f8f-95b5-10c2d4027a21

📥 Commits

Reviewing files that changed from the base of the PR and between 03666b9 and 27dbb3b.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • README.md
  • debian/changelog
  • src/Command/RunTemplate/AssignCredentialCommand.php
  • src/Command/RunTemplate/ListCredentialsCommand.php
  • src/Command/RunTemplate/UnassignCredentialCommand.php
  • tests/src/Command/RunTemplateTest.php

📝 Walkthrough

Walkthrough

This PR renames the RunTemplate identifier option from --runtemplate_id to --id across three CLI commands (assign-credential, unassign-credential, list-credentials), updates all related tests and documentation to reflect the consistent naming.

Changes

RunTemplate credential commands option rename

Layer / File(s) Summary
Rename --runtemplate_id to --id in three commands
src/Command/RunTemplate/AssignCredentialCommand.php, src/Command/RunTemplate/ListCredentialsCommand.php, src/Command/RunTemplate/UnassignCredentialCommand.php
AssignCredentialCommand, ListCredentialsCommand, and UnassignCredentialCommand now define and validate a required --id option instead of --runtemplate_id for the RunTemplate identifier, with matching error messages updated throughout.
Update command option assertions in tests
tests/src/Command/RunTemplateTest.php
RunTemplateTest now asserts that assign-credential, unassign-credential, and list-credentials commands define an id option instead of runtemplate_id.
Document option rename in changelogs and user docs
CHANGELOG.md, debian/changelog, README.md
CHANGELOG.md, debian/changelog, and README.md are updated to document the --id option naming for credential management commands and to describe the v2.5.5 fix and v2.5.4 feature additions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop and a skip through options we go,
From runtemplate_id to --id, so clean and so low,
Three commands now speak with consistent refrain,
Tests dance in alignment, docs flow like rain! 🌟

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/credential-command-id-option

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Vitexus Vitexus merged commit 66324e8 into main May 28, 2026
2 of 3 checks passed
@Vitexus Vitexus deleted the fix/credential-command-id-option branch May 28, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant