Skip to content

Series sorting and fixed caching#96

Merged
Vito0912 merged 2 commits intomainfrom
feat/seriesSorting
Nov 22, 2024
Merged

Series sorting and fixed caching#96
Vito0912 merged 2 commits intomainfrom
feat/seriesSorting

Conversation

@Vito0912
Copy link
Owner

This PR should finally close #88 this time.
The following key are available for sorting:
Name, Number of Books, Total Duration, Added (At)

Filtering is disabled for series

This PR also fixes caching that did not cache routes with query parameters which should speedup library loadtimes a lot

Copilot summary:
This pull request includes several changes to the lib/features directory, focusing on enhancing the NotchContent and SortButton components, improving the Home and SeriesViewWrapper widgets, and making some general code cleanups.

Enhancements to NotchContent and SortButton:

Improvements to Home and SeriesViewWrapper widgets:

General code cleanups:

These changes improve the flexibility and functionality of the sorting and filtering features within the application, while also simplifying the codebase and enhancing user navigation.

@Vito0912 Vito0912 merged commit c85e714 into main Nov 22, 2024
@Vito0912 Vito0912 deleted the feat/seriesSorting branch November 22, 2024 20:32
@kuldan5853
Copy link

I think I found another bug - if you do a search in the series view, and then exit. it returns to the unsorted view - if you then re-enable the sorting it only shows 15 series (in my case a-d or w-t) - to get it working you need to leave the series tab and go to one of the other and then re-enter the series tab, then it works like expected again

@Vito0912
Copy link
Owner Author

@kuldan5853 Created a new issue for three issues regarding searching.

For me, searching a series and clicking shows that no series is found, but is working for my dev device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Make Series-Tab searchable and sortable

2 participants