Conversation
|
I think I found another bug - if you do a search in the series view, and then exit. it returns to the unsorted view - if you then re-enable the sorting it only shows 15 series (in my case a-d or w-t) - to get it working you need to leave the series tab and go to one of the other and then re-enter the series tab, then it works like expected again |
Owner
Author
|
@kuldan5853 Created a new issue for three issues regarding searching. For me, searching a series and clicking shows that no series is found, but is working for my dev device. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should finally close #88 this time.
The following key are available for sorting:
Name, Number of Books, Total Duration, Added (At)
Filtering is disabled for series
This PR also fixes caching that did not cache routes with query parameters which should speedup library loadtimes a lot
Copilot summary:
This pull request includes several changes to the
lib/featuresdirectory, focusing on enhancing theNotchContentandSortButtoncomponents, improving theHomeandSeriesViewWrapperwidgets, and making some general code cleanups.Enhancements to
NotchContentandSortButton:lib/features/library/notch/notch_content.dart: Added new propertiessortKeysand updated theSortButtonto acceptoverwriteSortOptionsto customize sort options. [1] [2]lib/features/library/notch/sort_button.dart: ModifiedSortButtonto includeoverwriteSortOptionsand implemented long-press functionality to set sorting options. [1] [2]Improvements to
HomeandSeriesViewWrapperwidgets:lib/features/home/home.dart: UpdatedNotchContentusage to include new properties and added default sorting for index 2. [1] [2]lib/features/library/series/series_view_wrapper.dart: AdjustedLibraryNotchto disable filters and addedseriesSortKeys.General code cleanups:
lib/features/library/item_components/item_series.dart: Simplified navigation by includingseries.idin the URL.lib/globals.dart: IntroducedseriesSortKeysfor consistent sorting options.These changes improve the flexibility and functionality of the sorting and filtering features within the application, while also simplifying the codebase and enhancing user navigation.