Skip to content

Host build config and setup tools fix#558

Merged
ramseymcgrath merged 1 commit intomainfrom
557-cant-create-donor-template-build-cmd-is-not-using-vfio-properly
Feb 28, 2026
Merged

Host build config and setup tools fix#558
ramseymcgrath merged 1 commit intomainfrom
557-cant-create-donor-template-build-cmd-is-not-using-vfio-properly

Conversation

@ramseymcgrath
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 28, 2026 04:18
@roomote-v0
Copy link
Copy Markdown

roomote-v0 Bot commented Feb 28, 2026

Rooviewer Clock   See task

Review complete. I've identified 1 issue that should be addressed:

  • Version mismatch: SETUPTOOLS_SCM_PRETEND_VERSION=0.0.0 creates inconsistency with declared version 0.14.13 in __version__.py

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@ramseymcgrath ramseymcgrath merged commit 309c1b7 into main Feb 28, 2026
13 of 24 checks passed
@ramseymcgrath ramseymcgrath deleted the 557-cant-create-donor-template-build-cmd-is-not-using-vfio-properly branch February 28, 2026 04:19
@github-actions
Copy link
Copy Markdown

E2E Integration Test Summary

Workflow Run: 851
Commit: 7185057
Branch: 558/merge
Triggered by: pull_request
Timestamp: Sat Feb 28 04:21:05 UTC 2026

Test Results

End-to-End Tests

E2E Tests: FAILED
⏸️ Security Scan: SKIPPED
⏸️ Performance Analysis: SKIPPED

Artifacts

  • Test reports and logs available in workflow artifacts
  • Artifacts retained for 7-30 days depending on type

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/device_clone/donor_info_template.py 60.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes several host/local build and packaging edge cases, including PCI BDF handling in donor template generation and container install reliability when .git metadata is unavailable.

Changes:

  • Extend donor template generation to match lspci output when the input BDF includes a domain prefix, and add tests for both BDF formats.
  • Fix host-side kernel header install command (dnf) and adjust local templating orchestration env/profile handling.
  • Improve container build/install robustness for setuptools-scm version inference; bump version + update changelog.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_donor_info_template.py Adds coverage for domain-prefixed and non-prefixed BDF parsing from lspci output.
src/device_clone/donor_info_template.py Normalizes BDF matching against lspci output; adjusts success/warning logging based on extraction results.
src/file_management/donor_dump_manager.py Fixes Fedora/RHEL family kernel header install command to use dnf.
pcileech.py Updates local templating env-var behavior and makes profile optional via getattr.
Containerfile Upgrades setuptools and uses SETUPTOOLS_SCM_PRETEND_VERSION to allow installs without .git.
src/version.py Version bump to 0.14.13 with updated build metadata.
CHANGELOG.rst Adds 0.14.13 entry and TOC link.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Containerfile
Comment thread pcileech.py
Comment thread src/device_clone/donor_info_template.py
Comment thread Containerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't create donor-template, build cmd is not using VFIO properly [BUG] 0.14.12

2 participants