Host build config and setup tools fix#558
Conversation
Review complete. I've identified 1 issue that should be addressed:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
E2E Integration Test SummaryWorkflow Run: 851 Test ResultsEnd-to-End Tests❌ E2E Tests: FAILED Artifacts
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR fixes several host/local build and packaging edge cases, including PCI BDF handling in donor template generation and container install reliability when .git metadata is unavailable.
Changes:
- Extend donor template generation to match
lspcioutput when the input BDF includes a domain prefix, and add tests for both BDF formats. - Fix host-side kernel header install command (
dnf) and adjust local templating orchestration env/profile handling. - Improve container build/install robustness for
setuptools-scmversion inference; bump version + update changelog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_donor_info_template.py | Adds coverage for domain-prefixed and non-prefixed BDF parsing from lspci output. |
| src/device_clone/donor_info_template.py | Normalizes BDF matching against lspci output; adjusts success/warning logging based on extraction results. |
| src/file_management/donor_dump_manager.py | Fixes Fedora/RHEL family kernel header install command to use dnf. |
| pcileech.py | Updates local templating env-var behavior and makes profile optional via getattr. |
| Containerfile | Upgrades setuptools and uses SETUPTOOLS_SCM_PRETEND_VERSION to allow installs without .git. |
| src/version.py | Version bump to 0.14.13 with updated build metadata. |
| CHANGELOG.rst | Adds 0.14.13 entry and TOC link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.