CVE-2014-0472 and CVE-2016-9013 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshnib212
reviewed
Apr 2, 2020
cves/CVE-2014-0472.yml
Outdated
| This VCC was discovered automatically via archeogit. This was where | ||
| I originally thought the problem was introduced, but this was a refactor | ||
| of moving where the function lived. | ||
| - commit: 5d568bcfa66916e3de61e0090c724c899debd981 |
There was a problem hiding this comment.
If a commit that was discovered isn't relevant or isn't the specific part in the code that where the VCC is introduced then it should be removed!
roshnib212
reviewed
Apr 2, 2020
| developer to get the tests running. However, the lesson to be learned here | ||
| would be when you're adding a new feature, especially a security based on, | ||
| look through the exisiting features of that component and how the new | ||
| feature would mesh and/or create unforessen complications with exisiting |
There was a problem hiding this comment.
Just in general for all your answers, I would stray away from using first person perspective.
roshnib212
reviewed
Apr 3, 2020
| feature patch to bring in multiple database support including Oracle | ||
| database which did include refactoring and moving around | ||
| the password that was used/created in the test database. | ||
| upvotes_instructions: | |
roshnib212
reviewed
Apr 3, 2020
cves/CVE-2014-0472.yml
Outdated
| This VCC was discovered automatically via archeogit. This was where | ||
| I originally thought the problem was introduced, but this was a refactor | ||
| of moving where the function lived. | ||
| - commit: 5d568bcfa66916e3de61e0090c724c899debd981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWEN 331 Research Work for CVE-2014-0472 (Django) and CVE-2016-9013 (Django)