Skip to content

Feature: Android support for UTF8-characters #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Feature: Android support for UTF8-characters #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0352494
Added check for useUtf8-option
morgenhaar Sep 11, 2019
5a8712b
Added useUtf8Charset in README
morgenhaar Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ const options = {
// Below are options only supported on Android
notification: {
enabled: true
}
},
useUtf8Charset: true
}

Upload.startUpload(options).then((uploadId) => {
Expand Down Expand Up @@ -154,6 +155,7 @@ Returns a promise with the string ID of the upload. Will reject if there is a c
|`field`|string|Required if `type: 'multipart'`||The form field name for the file. Only used when `type: 'multipart`|`uploaded-file`|
|`parameters`|object|Optional||Additional form fields to include in the HTTP request. Only used when `type: 'multipart`||
|`notification`|Notification object (see below)|Optional||Android only. |`{ enabled: true, onProgressTitle: "Uploading...", autoClear: true }`|
|`useUtf8Charset`|boolean|Optional||Android only. Set to true to use `utf-8` as charset. ||

### Notification Object (Android Only)
|Name|Type|Required|Description|Example|
Expand Down
10 changes: 8 additions & 2 deletions android/src/main/java/com/vydia/UploaderModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,14 @@ public void onCancelled(Context context, UploadInfo uploadInfo) {
return;
}

request = new MultipartUploadRequest(this.getReactApplicationContext(), customUploadId, url)
.addFileToUpload(filePath, options.getString("field"));
if(options.hasKey("useUtf8Charset") && options.getBoolean("useUtf8Charset")) {
request = new MultipartUploadRequest(this.getReactApplicationContext(), customUploadId, url)
.setUtf8Charset()
.addFileToUpload(filePath, options.getString("field"));
} else {
request = new MultipartUploadRequest(this.getReactApplicationContext(), customUploadId, url)
.addFileToUpload(filePath, options.getString("field"));
}
}


Expand Down