Reduce debug-output in high-frequented parts #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reduces debug output in framework code sections that are frequently executed to improve performance and reduce console noise. The changes comment out debug logging statements in high-traffic methods like object getters, setters, and event handling.
- Comments out debug logging in frequently called methods across multiple framework files
- Adds null check for Element in DOMaddEventListener method
- Removes unnecessary blank line in reset method
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| www/sysObjFormfieldItem.js | Comments out debug logs in FormItemInit, FormItemGetValue, and reset methods |
| www/sysFactory.js | Comments out debug log in getObjectByID method |
| www/sysBaseObject.js | Comments out debug log in getObjectData method |
| www/sysBaseDOMElement.js | Comments out debug logs in removeDOMElement and setDOMElementValue methods, adds null check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Some framework code sections generate too much debug-output when highly frequented (e.g. object set / get value or similar). They must be commented out.
Type of Change
Additional Notes
It could also be a performance enhancement.