fix truthiness check; safety check around bin count#476
Merged
joefutrelle merged 1 commit intomasterfrom Oct 22, 2025
Merged
Conversation
Contributor
|
LGTM, good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a few minor bugs that were not directly found in the wild, but could be an issue
True if dataset else False. Because len is defined, that is used as truthiness rather than the default on an ORM model, which is to just return True (whether the model is saved or not). The included bool method takes precedence and both corrects the logic, and also prevents accidental usage of len in a conditional statement that would make a database call that might not be expected