Skip to content

fix(StudentData): Send response as UTF-8 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 1 commit into from
Aug 12, 2022
Merged

fix(StudentData): Send response as UTF-8 #172

hirokiterashima merged 1 commit into from
Aug 12, 2022

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 11, 2022

Changes

  • Convert StudentGetDataController to RestController and return HashMap containing values instead of writing to response
  • Clean up code

Test

  • Try saving こんにちは as student response and make sure that it loads and displays correctly when you refresh the browser
  • Other component data are loaded correctly (as before)

Closes #171

@hirokiterashima hirokiterashima self-assigned this Aug 11, 2022
geoffreykwan
geoffreykwan approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit be980fb into develop Aug 12, 2022
@hirokiterashima hirokiterashima deleted the issue-171-bug-retrieving-non-english-student-text branch August 12, 2022 16:31
@geoffreykwan
Copy link
Member

geoffreykwan commented Nov 27, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

released

Projects

WISE Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue retrieving non-english student text

3 participants

@hirokiterashima @geoffreykwan