refactor(MatchChoiceItem): Convert to standalone (2nd try)#2073
Merged
hirokiterashima merged 6 commits intodevelopfrom Jan 29, 2025
Merged
refactor(MatchChoiceItem): Convert to standalone (2nd try)#2073hirokiterashima merged 6 commits intodevelopfrom
hirokiterashima merged 6 commits intodevelopfrom
Conversation
… MatchChoiceItemComponent and is already imported there.
hirokiterashima
approved these changes
Jan 29, 2025
Member
hirokiterashima
left a comment
hirokiterashima
left a comment
There was a problem hiding this comment.
LGTM. I removed DeleteChoiceButtonComponent import from MatchCommonModule. It is only used in MatchChoiceItemComponent and is already imported there.
Member
|
🎉 This issue has been resolved in version 5.168.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test
Closes #2051