-
Notifications
You must be signed in to change notification settings - Fork 5
feat(DialogGuidance): Show idea detection rubric in grading tool #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DialogGuidance): Show idea detection rubric in grading tool #2140
Conversation
hirokiterashima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start. Seems to work as described.
I noticed that if you close the dialog by hitting the escape button, subsequent dialogs won't appear.
@breity can you please take a stab at styling?
Also, see my code improvement suggestions inline.
src/assets/wise5/components/common/cRater/crater-rubric/crater-rubric.component.ts
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/dialogGuidance/dialog-responses/dialog-responses.component.html
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/dialogGuidance/dialog-responses/dialog-responses.component.ts
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/common/cRater/crater-rubric/crater-rubric.component.html
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/common/cRater/crater-rubric/crater-rubric.component.html
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/common/cRater/crater-rubric/crater-rubric.component.ts
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/common/cRater/crater-rubric/crater-rubric.component.ts
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/common/cRater/crater-rubric/crater-rubric.component.ts
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/common/cRater/crater-rubric/crater-rubric.component.html
Outdated
Show resolved
Hide resolved
src/assets/wise5/components/dialogGuidance/dialog-responses/dialog-responses.component.ts
Outdated
Show resolved
Hide resolved
…b.com/WISE-Community/WISE-Client into issue-2126-show-idea-detection-rubric
…b.com/WISE-Community/WISE-Client into issue-2126-show-idea-detection-rubric
…b.com/WISE-Community/WISE-Client into issue-2126-show-idea-detection-rubric
Add keyboard accessibility to "Detectable ideas" links.
breity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good. 👍
I updated the styles and added keyboard accessibility to the "Detectable ideas" links.
hirokiterashima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
00b80b3
into
add-description-to-crater-rubric
Changes
Test
Closes #2126