Skip to content

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Apr 15, 2025

Changes

  • Added a dialog window that pops up in the bottom right of the screen when "Show detectable ideas" is clicked. This window shows the description of the AI model if one has been authored, and it displays all ideas that the AI model is looking for, along with any student-friendly descriptions that have been provided for those ideas.
  • Extracted IdeaData type to its own class along with two functions for converting between IdeaData and CRaterIdea.

Test

  • Clicking "Detectable ideas rubric" opens the rubric.
  • Clicking the X in the corner closes the rubric.
  • If a description for the AI model has been authored, it is shown above the table.
  • If no description for the AI model has been authored, nothing is shown between the title and the table.
  • All the ideas the CRater is trying to detect are in the table.
  • Only the ideas the CRater is trying to detect are in the table (random entries in ideaDescriptions are ignored).
  • Idea IDs are sorted alphanumerically.
  • If no idea description has been authored for an idea, the description cell is left empty.
  • Long idea descriptions wrap around to a new line.
  • The link to the rubric doesn't appear during the AI chat on a dialog guidance component.

Closes #2126

@Aaron-Detre Aaron-Detre self-assigned this Apr 16, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Apr 16, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 17, 2025 01:18
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start. Seems to work as described.

I noticed that if you close the dialog by hitting the escape button, subsequent dialogs won't appear.

@breity can you please take a stab at styling?

Also, see my code improvement suggestions inline.

@hirokiterashima hirokiterashima changed the title Show idea detection rubric in Dialog Guidance grading tool feat(DialogGuidance): Show idea detection rubric in grading tool Apr 22, 2025
Add keyboard accessibility to "Detectable ideas" links.
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good. 👍

I updated the styles and added keyboard accessibility to the "Detectable ideas" links.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Aaron-Detre Aaron-Detre merged commit 00b80b3 into add-description-to-crater-rubric Apr 28, 2025
2 checks passed
@Aaron-Detre Aaron-Detre deleted the issue-2126-show-idea-detection-rubric branch April 28, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants