refactor(LibraryService): Move ProjectFilterValues out of class #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokiterashima
changed the title
Aaron-Detre
approved these changes
May 8, 2025
Contributor
Aaron-Detre
left a comment
Aaron-Detre
left a comment
There was a problem hiding this comment.
Everything looks good, but I did find one problem, though I'm not sure if it's an issue to do with this pull request. When I type in "localhost/curriculum/personal" (or /public), I get a "Whitelabel Error Page." The same thing happens if I go from the curriculum to the community or research sites and then click the go back button. I checked on production and it's not happening there, so I'm not sure whether it's an issue with this branch or just my local environment.
hirokiterashima
deleted the
refactor-project-filter-move-out-of-library-service
branch
Member
Author
|
🎉 This PR is included in version 5.181.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We used to store an instance of ProjectFilterValue in LibraryService. Now, we use the provider field instead to share the instance among the components (ProjectFilter, Curriculum, ProjectLibrary)
Test