Refactored code to use Subscription.add#78
Merged
geoffreykwan merged 3 commits intodevelopfrom Apr 16, 2021
Merged
Conversation
For components that had multiple observable subscriptions, I replaced with a shared Subscription. For components with single subscription, I left it the same. Also: - removed unused dependencies in controllers - removed unnecessary variable declarations in controllers - removed EditComponentController because it's no longer used
hirokiterashima
pushed a commit
to encorelab/SCORE-Client
that referenced
this pull request
Jun 28, 2021
…70-ta-next-step WISE-Community#70 approve moves student to the next step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Additional changes
In those affected files, I also cleaned up the code:
Test
Closes #66