Skip to content

fix(RouterTrace): Correct types after RouteInfo simplification #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
Merged

fix(RouterTrace): Correct types after RouteInfo simplification #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/lib/RouterTrace/RouterTrace.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
import { routePatternsKey, RouterEngine } from '$lib/kernel/RouterEngine.svelte.js';
import { resolveHashValue } from '$lib/kernel/resolveHashValue.js';
import { getRouterContext } from '$lib/Router/Router.svelte';
import type { PatternRouteInfo } from '$lib/types.js';
import type { HTMLTableAttributes } from 'svelte/elements';
import { assertAllowedRoutingMode } from '$lib/utils.js';
import type { Hash } from '$lib/types.js';

type Props = Omit<HTMLTableAttributes, 'children'> & {
/**
Expand Down Expand Up @@ -34,7 +34,7 @@
* Unlike other components, the `RouterTrace` component does not need a hash value if a router engine object is
* provided in its stead via the `router` property.
*/
hash?: boolean | string;
hash?: Hash;
/**
* Sets the router engine to trace.
*/
Expand Down Expand Up @@ -127,12 +127,12 @@
{#each Object.entries(router.routeStatus) as [key, status]}
<tr>
<td>{key}</td>
{#if typeof (router.routes[key] as PatternRouteInfo).pattern === 'string'}
{#if typeof router.routes[key].path === 'string'}
<td>
<pre>{(router.routes[key] as PatternRouteInfo).pattern}</pre>
<pre>{router.routes[key].path}</pre>
</td>
{/if}
<td colspan={typeof (router.routes[key] as PatternRouteInfo).pattern === 'string' ? 1 : 2}>
<td colspan={typeof router.routes[key].path === 'string' ? 1 : 2}>
<code>{routePatterns.get(key)?.regex}</code>
</td>
<td>
Expand Down