Add Embeddable Taxonomy Term Links to the Post Response by rachelbaker · Pull Request #1048 · WP-API/WP-API

rachelbaker · 2015-04-03T18:08:52Z

Fixes #900

The _links in the Post response now include embeddable references for each object taxonomy.

…y post.

…rms route.

rachelbaker · 2015-04-03T18:17:55Z

In v1 the taxonomy terms were included in the Post response, this moves them to embeddable resource links. Any taxonomy that is returned by wp_get_object_taxonomies() is shown, which matches v1 behavior.

danielbachhuber · 2015-04-03T18:58:26Z

lib/endpoints/class-wp-json-terms-controller.php

Shouldn't we validate the taxonomy for the post type?

…th the given taxonomy.

rachelbaker · 2015-04-05T18:36:18Z

@danielbachhuber db2c077 adds checks to be sure a post exists and that the taxonomy is related to the post.

danielbachhuber · 2015-04-06T13:30:45Z

lib/endpoints/class-wp-json-terms-controller.php

Why isn't this just returning bool? I don't understand why you'd need $taxonomy returned when you're passing it in the first place.

danielbachhuber · 2015-04-06T13:36:24Z

lib/endpoints/class-wp-json-posts-controller.php

Need to check the taxonomy isn't private. This would benefit from a test.

WordPress doesn't have private taxonomies: https://core.trac.wordpress.org/ticket/21949 Related #419

We still need to check. Otherwise we will be exposing private data.

Added in line 1156

danielbachhuber · 2015-04-06T13:38:51Z

Just a few nits.

rachelbaker · 2015-04-15T22:49:37Z

I found a big hole in my logic here. I need to check that a user has permission to read a post before we return the terms associated with it. Still a WIP.

… and get_item methods.

- Renamed method check_valid_taxonomy_for_post to check_post_taxonomy_permission. - Return either a WP_Error or null.

…logic.

…ost_tag taxonomy.

…am from taxonomy validation.

rachelbaker · 2015-04-17T20:29:36Z

Includes:

checks to make sure a user can read a post before returning terms related to a given post_id
checks to make sure a taxonomy is public
added permission_callback methods.
unit tests
wraps responses in json_ensure_response

danielbachhuber · 2015-04-17T20:31:24Z

lib/endpoints/class-wp-json-terms-controller.php

Why return null?

It just returns....what would you do?

rachelbaker · 2015-04-17T20:59:10Z

@danielbachhuber Both pieces of recent feedback have been addressed in 82ac7d2 and de7b818

Add Embeddable Taxonomy Term Links to the Post Response

rachelbaker added 4 commits April 3, 2015 12:04

Add embeddable term links to the Post response.

38dd70d

Pinking shears.

38c9723

Add post query param to the terms/taxonomy route to filter response b…

3997cc9

…y post.

Correct structure of the taxonomy links, and reference new related te…

a444e78

…rms route.

rachelbaker added Review Feature Parity labels Apr 3, 2015

rachelbaker added this to the 2.0 Beta 1 milestone Apr 3, 2015

rachelbaker added 2 commits April 3, 2015 13:20

Correct taxonomy link paths in unit tests.

419524f

Use the correct array key for taxonomy links hrefs.

1f79ac6

danielbachhuber reviewed Apr 3, 2015
View reviewed changes

lib/endpoints/class-wp-json-terms-controller.php Outdated

Copy link
Copy Markdown

Member

danielbachhuber Apr 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we validate the taxonomy for the post type?

Add checks to be sure a post exists and that it has a relationship wi…

db2c077

…th the given taxonomy.

danielbachhuber reviewed Apr 6, 2015
View reviewed changes

danielbachhuber mentioned this pull request Apr 6, 2015

register_taxonomy() should support our controller registration arguments #1061

Closed

danielbachhuber reviewed Apr 6, 2015
View reviewed changes

danielbachhuber removed the Review label Apr 6, 2015

danielbachhuber assigned rachelbaker Apr 6, 2015

Merge branch 'develop' into add-tag-and-cat-links-fix

4fe2a40

rachelbaker added 8 commits April 17, 2015 11:22

Add read permission callbacks for WP_JSON_Terms_Controller::get_items…

b8f0fea

… and get_item methods.

Refactor post and taxonomy permission check.

8d25777

- Renamed method check_valid_taxonomy_for_post to check_post_taxonomy_permission. - Return either a WP_Error or null.

Only list public taxonomies in the _links entity.

84d27c3

Check a user has access to a post before providing the terms.

ef41723

Merge branch 'develop' into add-tag-and-cat-links-fix

a836641

Get the taxonomy object to check if it is public.

0416d83

Use the permission callback when creating a term to reduce duplicate …

6bf9c00

…logic.

Create handle_taxonomy_request method to sanitize and normalize the p…

d6ff9dc

…ost_tag taxonomy.

rachelbaker added 6 commits April 17, 2015 14:18

Separate logic that normalizes post_tag and sanitizes the request par…

73ec0af

…am from taxonomy validation.

Wrap our endpoint responses in response objects.

790e905

Add back errors when updating or deleting terms that don't exist.

1e0c779

Add tests.

8dcae60

Remove custom taxonomies from terms tests during teardown.

59c659b

Merge branch 'develop' into add-tag-and-cat-links-fix

0a6c8dd

danielbachhuber reviewed Apr 17, 2015
View reviewed changes

rachelbaker added 2 commits April 17, 2015 15:43

Return true if post access if allowed in check_post_taxonomy_permission.

de7b818

Normalize the post_tags endpoint to tags.

82ac7d2

danielbachhuber added a commit that referenced this pull request Apr 17, 2015

Merge pull request #1048 from WP-API/add-tag-and-cat-links

cd6e309

Add Embeddable Taxonomy Term Links to the Post Response

danielbachhuber merged commit cd6e309 into develop Apr 17, 2015

danielbachhuber deleted the add-tag-and-cat-links branch April 17, 2015 21:06

rachelbaker mentioned this pull request Apr 19, 2015

Increase Terms Controller test coverage #1117

Merged

Conversation

rachelbaker commented Apr 3, 2015

Uh oh!

rachelbaker commented Apr 3, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rachelbaker commented Apr 5, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielbachhuber commented Apr 6, 2015

Uh oh!

rachelbaker commented Apr 15, 2015

Uh oh!

rachelbaker commented Apr 17, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rachelbaker commented Apr 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants