BUG: namedGroup not determined correctly

[cawa-93]

node-wpapi/lib/route-tree.js

Line 36 in 7427d6f

var namedGroup = component.match( namedGroupRE );

// component == (?P<post_ids>([a-zA-Z0-9_]\,?)+)
var namedGroup = component.match( namedGroupRE );
/*
 [ '(?P<post_ids>([a-zA-Z0-9_]\\,?)', 
  'post_ids',
  '([a-zA-Z0-9_]\\,?', <-- ERROR in RegExp: Unterminated group
  index: 0,
  input: '(?P<post_ids>([a-zA-Z0-9_]\\,?)+)' ]
*/

node-wpapi/lib/route-tree.js

Line 83 in 7427d6f

new RegExp( groupPattern ? '^' + groupPattern + '$' : component, 'i' );

SyntaxError: Invalid regular expression: /^([a-zA-Z0-9_]\,?$/: Unterminated group
    at new RegExp (<anonymous>)
    at reduceRouteComponents (D:\Develop\parser\node_modules\wpapi\lib\route-tree.js:93:3)
    at Array.reduce (<anonymous>)
    at reduceRouteTree (D:\Develop\parser\node_modules\wpapi\lib\route-tree.js:193:18)
    at D:\Develop\parser\node_modules\wpapi\lib\util\object-reduce.js:24:10
    at Array.reduce (<anonymous>)
    at module.exports (D:\Develop\parser\node_modules\wpapi\lib\util\object-reduce.js:23:28)
    at buildRouteTree (D:\Develop\parser\node_modules\wpapi\lib\route-tree.js:208:9)
    at WPAPI.bootstrap (D:\Develop\parser\node_modules\wpapi\wpapi.js:348:23)
    at new WPAPI (D:\Develop\parser\node_modules\wpapi\wpapi.js:89:4)
    at D:\Develop\parser\node_modules\wpapi\wpapi.js:447:11
    at tryCatch (D:\Develop\parser\node_modules\es6-promise\dist\es6-promise.js:410:12)
    at invokeCallback (D:\Develop\parser\node_modules\es6-promise\dist\es6-promise.js:425:13)
    at publish (D:\Develop\parser\node_modules\es6-promise\dist\es6-promise.js:393:7)
    at flush (D:\Develop\parser\node_modules\es6-promise\dist\es6-promise.js:121:5)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)

[kadamwhite]

@cawa-93 Thanks for the issue report. I'm not sure how to interpret the ticket, I'm afraid. There is no invalid regular expression within this library's code --- I assume from your description that you have a plugin which supplies a route which is parsed into an incorrect regular expression?

If you can share the route string which is causing this issue, I'll see whether I can identify the shortcoming in our logic. Thanks!

[kadamwhite]

I'm going to close this due to lack of response; I do not currently have enough information to replicate or debug the issue. If you continue to experience this bug, please add a comment or open a new issue to keep the conversation going. Thank you for your bug report, and for using the library!

[SamiSousa]

I'm getting a similar issue when using the "bootstrapping" method for registering my site's supported routes rather than by using discovery:

SyntaxError: Invalid regular expression: /^[^.\/]+(?:\/[^.\/]+$/: Unterminated group

Not sure what causes this, since it worked before I added some new plugins, namely WP REST Filter and a custom edit to the ACF to WP API plugin.

I'm populating WPAPI like so:

const wp = new WPAPI({ endpoint: SITE_ENDPOINT, routes: SITE_API_RESPONSE.routes });

Where SITE_API_RESPONSE is the json returned by my site's /wp-json route.

[SamiSousa]

Found the issue for me, removing the /wp/v2/plugins/(?P<plugin>[^.\\/]+(?:\\/[^.\\/]+)?) route key and object from the JSON used with WPAPI avoids the error. The regular expression matches the one from the error for the first part, but it actually DOES terminate the group. Why is WPAPI omitting )?) from the string?

[SamiSousa]

Found the issue for me, removing the /wp/v2/plugins/(?P<plugin>[^.\\/]+(?:\\/[^.\\/]+)?) route key and object from the JSON used with WPAPI avoids the error. The regular expression matches the one from the error for the first part, but it actually DOES terminate the group. Why is WPAPI omitting )?) from the string?

It would seem that WPAPI's regular expression checker doesn't check for a (?:<pattern>) group nested within the initial pattern group.

[sebakerckhof]

Workaround in wordpress:

add_filter( 'rest_endpoints', 'remove_default_endpoints_smarter' );
  
function remove_default_endpoints_smarter( $endpoints ) {
	//  workaround for npm wpapi bug
  foreach ( $endpoints as $endpoint => $details ) {
		if (strpos($endpoint, 'plugins') !== false) {
			unset( $endpoints[$endpoint] );
		}
  }
 
  return $endpoints;
}

[Triloworld]

Pleas reopen - find that bug. Fix from @sebakerckhof help but that disable route and don't fix new patterns like "(?:)" as @SamiSousa mention