Added support for array filters #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the ' brackets' option for handling arrays. Which will automatically support array query expressions like post__in
|
Rebased and merged! @brad-decker, it would probably be good to fetch the latest version of my repo, then to hard-reset your master to mine—looks like your branch lagged a bit, which was all my rebase did to clean things up. I think this git walkthrough may touch on rebasing and branch management, if not let me know and I'll try to find another good resource! |
|
Thanks @kadamwhite ! will do. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all that needed to be done to support array filters like post__in properly was to update the qs package to latest version and pass the 'brackets' option for arrayFormat to qs.stringify. You also need to add post__in and post__not_in to query_vars on your wordpress install.