Add integration tests for post creation & updating #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a variable makes it less likely that errors will be introduced by mis-typing "success"; variable naming can be checked via JSHint.
These methods only take a callback as a function; specifying properties on that function is irrelevant from the client's point of view.
Without being able to pass a data object, all that .delete can do for a post object is to trash it: without passing a data object other resources, such as users, cannot be deleted at all (there is no such thing as a trashed user, so `force: true` MUST be passed in order to trigger a user record deletion)
It was inconsistent that authentication could be specified as key-value pairs when creating the WP instance, but not when calling the .auth() method on a WPRequest chain. This alters WPRequest's .auth() method to take EITHER the previously-supported two-string-arguments for username and password, OR an object with 'username' and 'password' strig properties.
kadamwhite
force-pushed
the
create-update-examples
branch
from
0ff92be to
0bce2c9
Compare
Due to [completely inexplicable "design" choices in NPM](npm/npm#3059), "prepublish" is _always_ run after `npm install`. This means that we _cannot_ run our entire test suite in prepublish, or else Travis (which `npm install`'s on each run) will (a) superfluously run the test suite twice, and (b) run the integration test suite (which is important to run before publish, but cannot be run in travis as there is no VM set up to field the requests). Removing the prepublish hook fixes the issue, though it does mean that we need to explicitly run all tests before publishing ('prepublish' used to be a safeguard). Additional changes: - Travis should test recent stable node versions, as well as iojs - Travis should also run ONLY the unit tests - Travis should use the "list" mocha reporter: "nyan" is adorable but really makes travis output illegible - `npm test` locally should run ALL tests, including integration suite
kadamwhite
force-pushed
the
create-update-examples
branch
from
0bce2c9 to
79be869
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that 403's are returned for some requests and 401's for others is a result of https://core.trac.wordpress.org/ticket/35527
This adds documentation and an integration test around a full post create-update-delete cycle