Move param() handling and renderQuery method to WPRequest #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters are more generic than filters: they can be useful on almost any API resource if they are used to specify context or to trigger data embedding. Moving these from CollectionRequest means that they will also be available on WPRequest derivatives like the paging `.next` and `.prev` requests, enabling consumers of the pagination queries to utilize methods like `.embed()`.
Collaborator
Author
|
TODO: move the corresponding unit tests from CollectionRequest's suite to WPRequest's |
This re-unites the tests with the object on which they are defined
Collaborator
Author
|
Done moving unit tests; merged branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters are more generic than filters: they can be useful on almost any API resource if they are used to specify context or to trigger data embedding. Moving these from CollectionRequest means that they will also be available on WPRequest derivatives like the paging
.nextand.prevrequests, enabling consumers of the pagination queries to utilize methods like.embed().