Switch .post() and .put() to .create() and .update() #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
After broadcasting this to the WCEU community, to anybody who comes to chime in: can you articulate
|
Collaborator
Author
|
Good chat. Provisionally merging, will see what feedback is like in tomorrow's presentation. |
kadamwhite
force-pushed
the
use-regular-verbs-not-rest-verbs
branch
from
34c5a29 to
58d2b81
Compare
This one has been a long time coming: POSTing a post to the posts endpoint is a linguistic nightmare, and HTTP verbs are part of the API interface that is best kept away from the users. This alters all of the existing GET, POST, PUT, DELETE and HEAD methods to be (semi)private and prefixed by `_http`, e.g. `_httpDelete`: The public interfaces for these (`.get`, `.create`, `.update`, `.delete` and `.headers`). `.post` and `.put` are maintained for the time being for back-compat but will be removed in 1.0.
kadamwhite
force-pushed
the
use-regular-verbs-not-rest-verbs
branch
from
58d2b81 to
4e05add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one has been a long time coming: POSTing a post to the posts endpoint is a linguistic nightmare, and HTTP verbs are part of the API interface that is best kept away from the users.
This alters all of the existing GET, POST, PUT, DELETE and HEAD methods to be (semi)private and prefixed by
_http, e.g._httpDelete: The public interfaces for these (.get,.create,.update,.deleteand.headers)..postand.putare maintained for the time being for back-compat but will be removed in 1.0.