Skip to content

Conversation

@goobta
Copy link
Member

@goobta goobta commented Dec 14, 2020

Just doing what I should have done a while ago. Since I hadn't disable push access to master until today.... I've kinda just been pushing to it (read: power trip). So for documentation's case, I'll list down everything's that been done so far:

  • Set up CI / CD (run tests + coverage)
  • Created a test to ensure that jupyter notebooks and scripts are links at push time
  • Created auto_trainer
    • So far only works with stable_baselines --will probably need to change that in the near future
    • Dynamic W&B compatibility
    • Docstrings
    • Tests
    • Turned into a package for auto install

So far, this is using stable-baselines as the algorithm implementations. If I can't figure out why stable-baselines's PPO2 implementation is causing a memory leak, my next step is going to be to create a Model interface so I can implement my own algorithms using Tensorflow 2 and/or TF-Agents.

@goobta goobta added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 14, 2020
@goobta goobta requested a review from mahajanrevant December 14, 2020 23:31
@coveralls
Copy link

coveralls commented Dec 14, 2020

Pull Request Test Coverage Report for Build 501311915

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+40.8%) to 89.865%

Totals Coverage Status
Change from base Build 421171462: 40.8%
Covered Lines: 133
Relevant Lines: 148

💛 - Coveralls

@goobta goobta mentioned this pull request Jan 20, 2021
Copy link
Member Author

@goobta goobta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed

@goobta goobta requested a review from mahajanrevant January 21, 2021 14:18
Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahajanrevant mahajanrevant merged commit eb27f74 into master Jan 21, 2021
@goobta goobta deleted the agupta231-cleaniness branch January 21, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants