Deploy should use the team number project setting

[ThomasJClark]

From #239

So, the entire right side of the window should be removed once #239 is merged, since we can get the team number from the setting (for the advanced option, we're going add a manual hostname setting anyways to the project settings)

[JLLeitschuh]

Actually, that's not true. You may want to deploy to a specific address.
The team number should default to the one from the project settings.

What if I want to publish to a network tables server running on my local computer but I'm deploying to a remote device.

[ThomasJClark]

I disagree. I am confident that literally 100% of teams will deploy to the same address that they use for a networktables server, which is always on the robot. They definitely also won't use two different team numbers.

It's possible that the robot might be at a different address besides the automatic mDNS one, but that can be solved with a manual hostname setting.

[JLLeitschuh]

@AustinShalit You want to weigh in on this one?

I want to deploy to the robot but use a table viewer on my local machine running a server.
I need to be able to set my deployment address to be different from where network tables is publishing to.

[bradamiller]

Why not leave it in for now? It will definitely help us with testing, then we don't need to have a program running on the roboRIO and can still test GRIP. It's for the same reason that the OutlineViewer can run as a client or a server, it makes it easy to test other things without the robot running code.

[JLLeitschuh]

So removing the UI is a wontfix but I will make it so that the UI uses the project as defaults.
This is also a low priority item.

[ThomasJClark]

I want to deploy to the robot but use a table viewer on my local machine running a server.

This is why the table viewer has an option to run as a client

Why not leave it in for now? It will definitely help us with testing, then we don't need to have a program running on the roboRIO and can still test GRIP. It's for the same reason that the OutlineViewer can run as a client or a server, it makes it easy to test other things without the robot running code.

This doesn't prevent us from running a networktables server locally for testing. NetworkTables defaults to localhost if it can't connect to the server

So removing the UI is a wontfix but I will make it so that the UI uses the project as defaults.

If there's really another option we want people to be able to change, put it in a project setting.

[AustinShalit]

I have never seen a case in competition where a team was running the NetworkTables server on anything other than the RoboRIO.

[JaciBrunning]

It would be nice to have an option for custom IP addresses, as some school networks may prevent mDNS discovery. Additionally, for those teams using co-processors, this option could be immensely useful.

[AustinShalit]

I agree with @JacisNonsense

[ThomasJClark]

I think that's a good plan. Basically, remove this configuration from the deploy panel, but have the project settings have an option for a custom address.

[JLLeitschuh]

The address you deploy to may be different from the address your network tables server is located though. Deploy location should not be a project setting.

[ThomasJClark]

The address you deploy to may be different from the address your network tables server is located though.

I agree

Deploy location should not be a project setting.

I disagree. That would mean you have to re-enter it every time, which would be super annoying if you're deploying over and over again.

I propose the following project settings:

• Team Number
• Robot address (team number is used if not specified)
• NetworkTables server address (robot address is used if not specified)