Skip to content

Logging feature#217

Merged
JLLeitschuh merged 11 commits intoWPIRoboticsProjects:masterfrom
PaulaRudy:loggingFeature
Dec 30, 2015
Merged

Logging feature#217
JLLeitschuh merged 11 commits intoWPIRoboticsProjects:masterfrom
PaulaRudy:loggingFeature

Conversation

@PaulaRudy
Copy link
Copy Markdown
Contributor

@PaulaRudy PaulaRudy commented Dec 21, 2015

Logging implemented where obvious. Logging goes to GRIPlogger.log in the same folder as main. Logging is done in text.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 21, 2015

Current coverage is 48.67%

Merging #217 into master will increase coverage by +0.41% as of 9f0b1f3

@@            master    #217   diff @@
======================================
  Files          104     104       
  Stmts         2505    2531    +26
  Branches       253     253       
  Methods          0       0       
======================================
+ Hit           1209    1232    +23
- Partial         46      47     +1
- Missed        1250    1252     +2

Review entire Coverage Diff as of 9f0b1f3

Uncovered Suggestions

  1. +0.48% via .../MainWindowView.java#84...95
  2. +0.44% via .../ExceptionAlert.java#95...105
  3. +0.40% via ...InputSocketView.java#36...45
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

JLLeitschuh
JLLeitschuh reviewed Dec 21, 2015
View reviewed changes
Comment thread core/src/main/java/edu/wpi/grip/core/Step.java Outdated
Copy link
Copy Markdown
Member

@JLLeitschuh JLLeitschuh Dec 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final

JLLeitschuh
JLLeitschuh reviewed Dec 30, 2015
View reviewed changes
Comment thread core/src/main/java/edu/wpi/grip/core/Step.java Outdated
Copy link
Copy Markdown
Member

@JLLeitschuh JLLeitschuh Dec 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be here.

JLLeitschuh added a commit that referenced this pull request Dec 30, 2015
@JLLeitschuh
Merge pull request #217 from PaulaRudy/loggingFeature
9a34cfd 
Logging feature
@JLLeitschuh JLLeitschuh merged commit 9a34cfd into WPIRoboticsProjects:master Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PaulaRudy @codecov-io @JLLeitschuh