Skip to content

Fixes TextAreaSocketPreviewView NullPointer #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2016
Merged

Fixes TextAreaSocketPreviewView NullPointer #242

merged 4 commits into from
Jan 4, 2016

Conversation

@JLLeitschuh
Copy link
Member

@JLLeitschuh JLLeitschuh commented Jan 3, 2016

GripPlatform wasn't assigned to its field in the constructor.

Closes #174

@JLLeitschuh
Fixes TextAreaSocketPreviewView NullPointer
b71266b 
GripPlatform wasn't assigned to its field in the constructor.

Closes WPIRoboticsProjects#174
@codecov-io
Copy link

codecov-io commented Jan 3, 2016

Current coverage is 50.28%

Merging #242 into master will increase coverage by +0.40% as of 6478fc8

@@            master    #242   diff @@
======================================
  Files          113     113       
  Stmts         3376    3377     +1
  Branches       358     358       
  Methods          0       0       
======================================
+ Hit           1684    1698    +14
  Partial        103     103       
+ Missed        1589    1576    -13

Review entire Coverage Diff as of 6478fc8

Uncovered Suggestions

  1. +0.71% via ...tionsController.java#68...91
  2. +0.68% via ...loyerController.java#99...121
  3. +0.62% via ...InstanceManager.java#174...194
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@JLLeitschuh JLLeitschuh mentioned this pull request Jan 4, 2016
Closed
ThomasJClark added a commit that referenced this pull request Jan 4, 2016
@ThomasJClark
Merge pull request #242 from JLLeitschuh/fix/textAreaNullPointer
c57067e 
Fixes TextAreaSocketPreviewView NullPointer
@ThomasJClark ThomasJClark merged commit c57067e into WPIRoboticsProjects:master Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready for review type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JLLeitschuh @codecov-io @ThomasJClark