Skip to content

Fixes TextAreaSocketPreviewView NullPointer #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2016
Merged

Fixes TextAreaSocketPreviewView NullPointer #242

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b71266b
Fixes TextAreaSocketPreviewView NullPointer
JLLeitschuh Jan 3, 2016
78121ef
Merge branch 'master' into fix/textAreaNullPointer
JLLeitschuh Jan 4, 2016
879e4b9
Merge branch 'master' into fix/textAreaNullPointer
JLLeitschuh Jan 4, 2016
89b9e47
Merge branch 'master' into fix/textAreaNullPointer
JLLeitschuh Jan 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ui/src/main/java/edu/wpi/grip/ui/preview/TextAreaSocketPreviewView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,18 @@
public class TextAreaSocketPreviewView<T> extends SocketPreviewView<T> {

private final TextArea text;
private GRIPPlatform platform;
private final GRIPPlatform platform;

/**
* @param socket An output socket to preview
* @param socket An output socket to preview
*/
public TextAreaSocketPreviewView(GRIPPlatform platform, OutputSocket<T> socket) {
super(socket);
this.platform = platform;

this.setStyle("-fx-pref-width: 20em;");

this.text = new TextArea(socket.getValue().orElse((T)"").toString());
this.text = new TextArea(socket.getValue().orElse((T) "").toString());
text.setEditable(false);

this.setContent(text);
Expand All @@ -34,7 +35,7 @@ public TextAreaSocketPreviewView(GRIPPlatform platform, OutputSocket<T> socket)
public void onSocketChanged(SocketChangedEvent event) {
final Socket socket = event.getSocket();
if (socket == this.getSocket()) {
platform.runAsSoonAsPossible(() ->{
platform.runAsSoonAsPossible(() -> {
this.text.setText(socket.getValue().orElse("").toString());
});
}
Expand Down