Skip to content

Fix some issues with ProjectSettings #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JLLeitschuh merged 1 commit into from
Jan 8, 2016
Merged

Fix some issues with ProjectSettings #318

JLLeitschuh merged 1 commit into from
Jan 8, 2016

Conversation

@ThomasJClark
Copy link
Contributor

@ThomasJClark ThomasJClark commented Jan 8, 2016

This includes null checks and lots of typos

Closes #317

@ThomasJClark ThomasJClark added this to the v1.0.0 milestone Jan 8, 2016
@ThomasJClark
Fix some issues with ProjectSettings
fe71439 
This includes null checks and lots of typos
@codecov-io
Copy link

codecov-io commented Jan 8, 2016

Current coverage is 48.86%

Merging #318 into master will decrease coverage by -0.12% as of 87c3a45

@@            master    #318   diff @@
======================================
  Files          123     123       
  Stmts         3689    3690     +1
  Branches       399     399       
  Methods          0       0       
======================================
- Hit           1807    1803     -4
- Partial        114     116     +2
- Missed        1768    1771     +3

Review entire Coverage Diff as of 87c3a45

Uncovered Suggestions

  1. +0.73% via ...loyerController.java#102...128
  2. +0.70% via ...tionsController.java#68...93
  3. +0.59% via ...InstanceManager.java#182...203
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

JLLeitschuh added a commit that referenced this pull request Jan 8, 2016
@JLLeitschuh
Merge pull request #318 from ThomasJClark/project-settings-fix
4252bdd 
Fix some issues with ProjectSettings
@JLLeitschuh JLLeitschuh merged commit 4252bdd into WPIRoboticsProjects:master Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JLLeitschuh JLLeitschuh

Labels

HIGH PRIORITY type: bug

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasJClark @codecov-io @JLLeitschuh