Skip to content

Fix connections not positioning correctly when loading project #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JLLeitschuh merged 2 commits into from
Jan 10, 2016
Merged

Fix connections not positioning correctly when loading project #322

JLLeitschuh merged 2 commits into from
Jan 10, 2016

Conversation

@ThomasJClark
Copy link
Contributor

@ThomasJClark ThomasJClark commented Jan 8, 2016

Also connections flickering when moving.

Closes #321

Before:
before

After:
after

@codecov-io
Copy link

codecov-io commented Jan 8, 2016

Current coverage is 48.32%

Merging #322 into master will decrease coverage by -0.05% as of a384335

@@            master    #322   diff @@
======================================
  Files          124     124       
  Stmts         3702    3702       
  Branches       402     402       
  Methods          0       0       
======================================
- Hit           1791    1789     -2
- Partial        110     111     +1
- Missed        1801    1802     +1

Review entire Coverage Diff as of a384335

Uncovered Suggestions

  1. +0.73% via ...loyerController.java#102...128
  2. +0.70% via ...tionsController.java#68...93
  3. +0.59% via ...InstanceManager.java#182...203
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@ThomasJClark ThomasJClark added this to the v1.0.0 milestone Jan 8, 2016
JLLeitschuh
JLLeitschuh reviewed Jan 9, 2016
View reviewed changes
ui/src/main/java/edu/wpi/grip/ui/pipeline/PipelineController.java
Copy link
Member

@JLLeitschuh JLLeitschuh Jan 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deadlock prone

JLLeitschuh added a commit that referenced this pull request Jan 10, 2016
@JLLeitschuh
Merge pull request #322 from ThomasJClark/deserialization-fix
936cef3 
Fix connections not positioning correctly when loading project
@JLLeitschuh JLLeitschuh merged commit 936cef3 into WPIRoboticsProjects:master Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JLLeitschuh JLLeitschuh

Labels

HIGH PRIORITY type: bug

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasJClark @codecov-io @JLLeitschuh