Fixes Versioning breaking with leading v#409
Merged
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom Jan 22, 2016
Merged
Fixes Versioning breaking with leading v#409JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
Conversation
Contributor
|
What about if the tag ends with "-rc1" or something? What about non-tagged commits, where it appends part of the hash? |
Member
Author
|
Those will work fine. Remember when we did the pre-release builds. Those build with no problem on linux. |
Member
Author
|
Also, for developers having the commit hash will give us the right commit to pull to put any stack traces in context. |
Current coverage is
|
JLLeitschuh
added a commit
that referenced
this pull request
Jan 22, 2016
Fixes Versioning breaking with leading v
Contributor
|
They won't work, I literally just tested this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.