Skip to content

Fixes Versioning breaking with leading v#409

Merged
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
JLLeitschuh:fix/versioningBreak
Jan 22, 2016
Merged

Fixes Versioning breaking with leading v#409
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
JLLeitschuh:fix/versioningBreak

Conversation

@JLLeitschuh
Copy link
Copy Markdown
Member

No description provided.

@ThomasJClark
Copy link
Copy Markdown
Contributor

What about if the tag ends with "-rc1" or something?

What about non-tagged commits, where it appends part of the hash?

@JLLeitschuh
Copy link
Copy Markdown
Member Author

Those will work fine. Remember when we did the pre-release builds. Those build with no problem on linux.

@JLLeitschuh
Copy link
Copy Markdown
Member Author

Also, for developers having the commit hash will give us the right commit to pull to put any stack traces in context.

@codecov-io
Copy link
Copy Markdown

Current coverage is 51.46%

Merging #409 into master will not affect coverage as of 27dd7b2

@@            master    #409   diff @@
======================================
  Files          122     122       
  Stmts         3614    3614       
  Branches       415     415       
  Methods          0       0       
======================================
  Hit           1860    1860       
  Partial        116     116       
  Missed        1638    1638       

Review entire Coverage Diff as of 27dd7b2


Uncovered Suggestions

  1. +0.58% via .../ExceptionAlert.java#83...103
  2. +0.42% via ...cketPreviewView.java#90...104
  3. +0.39% via ...cketPreviewView.java#38...51
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

JLLeitschuh added a commit that referenced this pull request Jan 22, 2016
Fixes Versioning breaking with leading v
@JLLeitschuh JLLeitschuh merged commit caf22a7 into WPIRoboticsProjects:master Jan 22, 2016
@ThomasJClark
Copy link
Copy Markdown
Contributor

They won't work, I literally just tested this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants