v1.1.0 for real#410
Merged
ThomasJClark merged 1 commit intoWPIRoboticsProjects:masterfrom Jan 22, 2016
Merged
Conversation
We **cannot** use `git describe` to generate versions, since you can't just use any arbitrary string as the version with JavaFX's packaging tools. .deb and .rpm builds both fail if you do this on a commit that isn't tagged, or is tagged in a way other than v1.1.0 (for example, release candidates)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot use
git describeto generate versions, since you can'tjust use any arbitrary string as the version with JavaFX's packaging
tools. .deb and .rpm builds both fail if you do this on a commit that
isn't tagged, or is tagged in a way other than v1.1.0 (for example,
release candidates)