Skip to content

Missing error check for SDL_SubmitGPUCommandBuffer in TextureWrapper #42

@coderabbitai

Description

@coderabbitai

Description

Missing error validation for SDL_SubmitGPUCommandBuffer in the texture upload path. If submission fails, the texture is still returned to the caller despite the upload potentially being incomplete.

Location

  • File: sdl_wrapper/src/sdl_wrapper.texture.cpp
  • Lines: ~97-98

Context

Flagged during code review of PR #41:

Expected Behavior

The function should check the return value of SDL_SubmitGPUCommandBuffer(cmd) and handle failures by cleaning up resources and returning an appropriate error code.


Requested by: @WSQS

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions