-
Notifications
You must be signed in to change notification settings - Fork 0
📝 Add docstrings to vertex_layout
#35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -70,11 +70,13 @@ void main() | |||||
|
|
||||||
| public: | ||||||
| /** | ||||||
| * @brief Initialize application resources, GPU pipeline, vertex data, and Dear ImGui. | ||||||
| * @brief Initialize application GPU resources, shaders, vertex data, camera, and Dear ImGui. | ||||||
| * | ||||||
| * Creates the GPU device, window/pipeline/buffer wrappers, compiles shaders, | ||||||
| * uploads the initial vertex data, initializes the camera to identity, | ||||||
| * and sets up Dear ImGui and its SDL3/SDLGPU backends. | ||||||
| * Performs creation of the GPU wrapper and render procedural, compiles and submits the vertex | ||||||
| * and fragment shaders, creates and uploads initial render data, sets the camera uniform to the | ||||||
| * identity matrix, and initializes Dear ImGui with SDL3 and SDLGPU backends. | ||||||
| * | ||||||
| * @return SDL_AppResult `SDL_APP_CONTINUE` on successful initialization, `SDL_APP_FAILURE` on error. | ||||||
| */ | ||||||
| SDL_AppResult init(int argc, char** argv) override | ||||||
| { | ||||||
|
|
@@ -192,7 +194,18 @@ void main() | |||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * @brief Advance the UI frame, present editors for triangle vertices and shader sources. | ||||||
| * @brief Advance the UI frame and present editors for vertex data and shader sources. | ||||||
| * | ||||||
| * Displays the ImGui demo and an "Editor" window with three modes: | ||||||
| * - Node/Vertex editing: exposes per-vertex attributes for editing and uploads the vertex buffer when modified. | ||||||
| * - Vertex shader editing: allows editing the vertex GLSL source and applies it to the procedural pipeline when | ||||||
| * changed. | ||||||
| * - Fragment shader editing: allows editing the fragment GLSL source and applies it to the procedural pipeline when | ||||||
| * changed. | ||||||
| * | ||||||
| * Any failures to upload vertex data or update shaders are logged. | ||||||
| * | ||||||
| * @return SDL_AppResult SDL_APP_CONTINUE to indicate the application should continue running. | ||||||
| */ | ||||||
| SDL_AppResult tick() | ||||||
| { | ||||||
|
|
@@ -296,7 +309,13 @@ void main() | |||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * @brief Render the triangle and ImGui UI to the GPU and present the swapchain frame. | ||||||
| * @brief Render the scene (triangle and ImGui) into the current swapchain image and present it. | ||||||
| * | ||||||
| * Performs pipeline submission if needed, prepares ImGui draw data, records GPU commands | ||||||
| * to clear and render the color target, uploads the camera uniform, binds vertex buffers | ||||||
| * and the graphics pipeline, issues the draw call, renders ImGui, and submits the command buffer. | ||||||
| * | ||||||
| * @return SDL_AppResult `SDL_APP_CONTINUE` to keep the application running. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'draw' can be made const [readability-make-member-function-const]
Suggested change
|
||||||
| */ | ||||||
| SDL_AppResult draw() | ||||||
| { | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method 'tick' can be made static [readability-convert-member-functions-to-static]