Small fixes#99
Merged
vdplasthijs merged 14 commits intodevelopfrom Apr 30, 2026
Merged
Conversation
Inference model, encoder wrapper and more
Change dependabot
Contributor
Author
|
Sorry, at first I put the wrong target branch. |
robknapen
approved these changes
Apr 24, 2026
Collaborator
robknapen
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for finding and fixing these!
vdplasthijs
requested changes
Apr 28, 2026
Collaborator
vdplasthijs
left a comment
There was a problem hiding this comment.
Thanks! Can we change quiet to verbose with logic that if verbose>0 things should be printed, for consistency? Thanks!
…to feature/set_up_encoders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
setup()method, found inBaseModelclass.PredictiveModelandEncoderWrapperto allow control and not normalise features twice.setup()call prints the model composition only once now.Before submitting
pytestcommand?