Conversation
SarahAlidoost
requested changes
Feb 25, 2026
Collaborator
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella Thanks! 👍 I left some comments/suggestions. Main issues:
- the sonar reliability issue about
shape, I wonder if my suggestion fixes the issue, let's see 🤔 - including output variable
WSTin the gradient tests
If something is unclear, let me know.
|
SarahAlidoost
approved these changes
Feb 25, 2026
Collaborator
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella thanks for addressing the comments, I see sonar is happy now 😄 let's merge 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46.
Notice that specific test data for the
Stem dynamicsmodule do not exist inwofost72, sotest_stem_dynamics.pyimplemented in this PR mainly checks the consistency of this new implementation (there are only a fewassert_is_closestatements) .However, the integration test
test_wofost_pp_with_stem_dynamicsconfirms that this new module numerically reproduces the correct results when used in combination with all the other wofost72's modules.