Skip to content

Moved module configuration beans, removed internal yaml configuration #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreacastello merged 1 commit into from
Apr 11, 2025
Merged

Moved module configuration beans, removed internal yaml configuration #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...com/scientiamobile/wurfl/devicedetection/config/WURFLDeviceDetectionConfigProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@

import java.util.Set;

@ConfigurationProperties(prefix = "hooks.modules." + WURFLDeviceDetectionModule.CODE)
@Data

public class WURFLDeviceDetectionConfigProperties {

private static final int DEFAULT_UPDATE_TIMEOUT = 5000;
Expand Down
13 changes: 9 additions & 4 deletions ...es/com/scientiamobile/wurfl/devicedetection/config/WURFLDeviceDetectionConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import org.prebid.server.hooks.modules.com.scientiamobile.wurfl.devicedetection.v1.WURFLDeviceDetectionModule;
import org.prebid.server.hooks.modules.com.scientiamobile.wurfl.devicedetection.v1.WURFLDeviceDetectionRawAuctionRequestHook;
import org.prebid.server.hooks.modules.com.scientiamobile.wurfl.devicedetection.v1.WURFLService;
import org.prebid.server.hooks.modules.com.scientiamobile.wurfl.devicedetection.config.WURFLDeviceDetectionConfigProperties;
import org.prebid.server.spring.env.YamlPropertySourceFactory;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.context.annotation.Bean;
Expand All @@ -17,20 +18,24 @@
import org.prebid.server.spring.config.model.FileSyncerProperties;
import org.prebid.server.spring.config.model.HttpClientProperties;
import org.prebid.server.execution.file.FileUtil;
import org.springframework.boot.context.properties.ConfigurationProperties;


import java.nio.file.Path;
import java.util.List;

@ConditionalOnProperty(prefix = "hooks." + WURFLDeviceDetectionModule.CODE, name = "enabled", havingValue = "true")
@Configuration
@PropertySource(
value = "classpath:/module-config/wurfl-devicedetection.yaml",
factory = YamlPropertySourceFactory.class)
@EnableConfigurationProperties(WURFLDeviceDetectionConfigProperties.class)
public class WURFLDeviceDetectionConfiguration {

private static final Long DAILY_SYNC_INTERVAL = 86400000L;

@Bean
@ConfigurationProperties(prefix = "hooks.modules." + WURFLDeviceDetectionModule.CODE)
WURFLDeviceDetectionConfigProperties configProperties() {
return new WURFLDeviceDetectionConfigProperties();
}

@Bean
public WURFLDeviceDetectionModule wurflDeviceDetectionModule(WURFLDeviceDetectionConfigProperties
configProperties, Vertx vertx) {
Expand Down
46 changes: 0 additions & 46 deletions ...modules/wurfl-devicedetection/src/main/resources/module-config/wurfl-devicedetection.yaml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions sample/configs/prebid-config-with-wurfl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,12 @@ hooks:
}
}


modules:
wurfl-devicedetection:
wurfl-file-dir-path: </path/to/wurfl_snapshot_dir>
wurfl-snapshot-url: https://data.scientiamobile.com/your_wurfl_snapshot_url/wurfl.zip
cache-size: 200000
wurfl-run-updater: true
allowed-publisher-ids: 1
ext-caps: true