Fixed error handling on /flowsheet/end and changed http method to POST#2
Merged
Conversation
6 tasks
jakebromberg
added a commit
that referenced
this pull request
May 6, 2026
This was referenced May 15, 2026
jakebromberg
added a commit
that referenced
this pull request
May 15, 2026
scripts/check-legacy-entry-id-writes.mjs enforces an allowlist of files that may contain `legacy_entry_id:` (object-literal key form). Each entry registers the use case: #1 webhook upsert, #2 mirror loop-guard, #3 ETL incremental sync, or "READS only" / "column declaration". A new write site without a registered rationale fails CI. - schema.ts: 16-line invariant comment on the column declaration enumerating the three uses and the failure mode (silently break the loop-guard). - flowsheet.mirror.ts addEntry guard: comment naming use #2 and cross- referencing the schema.ts invariant + the CI check. - tests/unit/scripts/check-legacy-entry-id-writes.test.ts: source-grep + child-process tests covering exit codes 0/1/2 and pinning the rationale taxonomy against the allowlist. - .github/workflows/test.yml: new "legacy_entry_id writes" step in the lint-and-typecheck job, alongside the existing cross-cache-identity guards. Closes #908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.