Fix flowsheet ETL show_id FK violation and timezone handling#300
Merged
jakebromberg merged 2 commits intomainfrom Apr 6, 2026
Merged
Fix flowsheet ETL show_id FK violation and timezone handling#300jakebromberg merged 2 commits intomainfrom
jakebromberg merged 2 commits intomainfrom
Conversation
jakebromberg
force-pushed
the
bugfix/etl-fixes
branch
from
4cd596e to
9883715
Compare
added 2 commits
April 5, 2026 17:20
…load show_id 0 would violate the FK constraint since no show has id 0. The incremental sync path already uses null correctly.
The previous implementation hardcoded UTC-4 (EDT), producing timestamps off by one hour for entries during EST (November-March). Uses Intl.DateTimeFormat to determine the correct Eastern offset at each datetime, with a two-pass approach to handle DST transition edge cases.
jakebromberg
force-pushed
the
bugfix/etl-fixes
branch
from
9883715 to
84bb8cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show_id: backendShowId ?? 0to?? nullin bulk load path (FK violation fix)-04:00EDT offset with dynamic EST/EDT resolution usingIntl.DateTimeFormatCloses #295
Test plan