perf: Set tables UNLOGGED before converter COPY in direct-PG mode#31
Merged
jakebromberg merged 1 commit intomainfrom Mar 10, 2026
Merged
perf: Set tables UNLOGGED before converter COPY in direct-PG mode#31jakebromberg merged 1 commit intomainfrom
jakebromberg merged 1 commit intomainfrom
Conversation
The UNLOGGED optimization was only applied in _run_database_build_post_import, which runs after the converter has already finished writing millions of rows via COPY to LOGGED tables. Move set_tables_unlogged into _run_xml_pipeline before the converter call so the heaviest I/O phase (bulk COPY from the Rust converter) benefits from skipping WAL writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_tables_unloggedinto_run_xml_pipelinebefore the converter call so COPY targets UNLOGGED tablesset_tables_unloggedfrom_run_database_build_post_importCloses #30. See also WXYC/discogs-xml-converter#18 (batch size increase).
Test plan
ruff format --check . && ruff check .passespytest tests/unit/ -v-- 318 passed