perf: use ProcessPoolExecutor for multi-core fuzzy matching#47
Merged
jakebromberg merged 3 commits intomainfrom Mar 11, 2026
Merged
perf: use ProcessPoolExecutor for multi-core fuzzy matching#47jakebromberg merged 3 commits intomainfrom
jakebromberg merged 3 commits intomainfrom
Conversation
added 3 commits
March 11, 2026 13:45
…ll CPU cores ThreadPoolExecutor was serializing on a single core because the Python loop overhead between rapidfuzz extractOne calls holds the GIL. ProcessPoolExecutor with fork context gives true multi-core parallelism. Also improves logging: Phase 3 now reports elapsed time, Phase 4 chunk logs include throughput (artists/s) and ETA, and chunks are smaller (~200 artists) for more frequent progress updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadPoolExecutortoProcessPoolExecutorwith fork context for true multi-core parallelism (the GIL was serializing threads on a single core)artists/s) and ETA to Phase 4 chunk logs, elapsed time to Phase 3 logPYTHONUNBUFFERED=1inrun_stepsubprocess environment so log lines stream immediately instead of being held in full-buffering pipe buffersCloses #46
Test plan
PYTHONUNBUFFERED=1is set in subprocess env and caller env vars are preserved--pruneand observe multi-core CPU usage and frequent chunk progress logs