Skip to content

Fix uncertainty buttons, add report_private, retro improvements, Friday dates#26

Open
WZ wants to merge 3 commits intomainfrom
fix/uncertainty-button-action-ids
Open

Fix uncertainty buttons, add report_private, retro improvements, Friday dates#26
WZ wants to merge 3 commits intomainfrom
fix/uncertainty-button-action-ids

Conversation

@WZ
Copy link
Owner

@WZ WZ commented Feb 16, 2026

Summary

  • Fix uncertainty sampling buttons: Use unique action IDs per button to avoid Slack collisions
  • Add report_private config option: When true, /generate-report DMs the report to the caller instead of posting to the channel
  • Show item descriptions in uncertainty messages: Display the work item text in low-confidence prompts
  • Fix retro Apply button: Use section labels in retro glossary apply, resolve IDs correctly
  • Retro suggestion improvements: Show full guide text, hide Apply when payload exceeds Slack's 2000-char button value limit
  • Rename /retrospective to /retrospect: Shorter command name
  • Docker-compose fix: Make glossary volume writable for auto-grow, add trailing newline
  • Friday dates in filenames: Report filenames and email subjects now use Friday (week end) instead of Monday
  • Boss report from team report: When running /generate-report boss, skip the LLM pipeline entirely if a team report for the same week already exists — derive the boss report directly from the team markdown

Test plan

  • /report items and /list work as before
  • /generate-report team produces a file with Friday date (e.g. MyTeam_20260213.md)
  • /generate-report boss after team report exists: skips LLM, derives from team report, outputs .eml with Friday date
  • /generate-report boss without existing team report: falls through to full LLM pipeline
  • .eml subject line uses Friday date
  • report_private: true sends report as DM
  • Uncertainty sampling buttons work without Slack errors
  • /retrospect suggestions show Apply/Dismiss correctly
  • CGO_ENABLED=1 go test -v ./... passes (35 tests)

🤖 Generated with Claude Code

… team report

- Add FridayOfWeek() helper to compute Friday from the week's Monday
- Change report filenames and email subjects from Monday to Friday date
- When generating boss report, skip LLM pipeline if team report already exists
  for the same week — read, parse, and re-render as boss mode instead
- Update findLatestReportBefore to match new Friday-based filenames
- Fix loadSectionOptionsForModal to use Monday from ReportWeekRange

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 16, 2026 10:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates weekly report generation to use Friday (“week ending”) dates in outputs and introduces a boss-report shortcut that derives directly from an existing team report, reducing LLM usage when possible.

Changes:

  • Add boss-mode fast path to derive the boss report from an existing team report file (skips LLM).
  • Switch report filenames and upload comments to use the week’s Friday date.
  • Add FridayOfWeek helper and adjust template-loading logic to use the correct week anchor date.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
slack.go Adds boss-from-team shortcut, switches generated report filenames/comments to Friday dates, and fixes modal template loading to anchor on the report week Monday.
report_builder.go Updates “current report” filename derivation to match Friday-based report naming.
models.go Introduces FridayOfWeek helper for consistent Friday date derivation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +365 to +367
teamReportPath := filepath.Join(cfg.ReportOutputDir, teamReportFile)
if content, readErr := os.ReadFile(teamReportPath); readErr == nil && len(content) > 0 {
log.Printf("generate-report boss: deriving from existing team report %s", teamReportPath)
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boss-mode shortcut treats any ReadFile error the same as “no existing team report”, so permission/IO errors will silently fall through to the full (token-consuming) pipeline. Handle readErr explicitly: if os.IsNotExist(readErr) continue, otherwise surface an ephemeral error (and log) and return.

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link

Copilot AI commented Feb 16, 2026

@WZ I've opened a new pull request, #27, to work on those changes. Once the pull request is ready, I'll request review from you.

WZ and others added 2 commits February 16, 2026 02:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI commented Feb 16, 2026

@WZ I've opened a new pull request, #28, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants