Modernize `MixedAuthenticatorTest` to use `List.of()` for empty authorities by Copilot · Pull Request #3328 · Waffle/waffle

Copilot · 2026-05-17T21:04:40Z

Modernizer flagged MixedAuthenticatorTest for legacy empty-list construction (Collections.emptyList()) in the Tomcat 9 test module. This updates the test to use the Java 9+ collection factory API expected by current rules while preserving behavior.

Scope
- Updated waffle-tomcat9 test code at MixedAuthenticatorTest (custom principal setup path).
Code modernization
- Replaced Collections.emptyList() with List.of() when constructing GenericPrincipal.
- Switched import from java.util.Collections to java.util.List.
Behavioral impact
- No functional change intended; the test still passes an empty role list to GenericPrincipal.

final GenericPrincipal genericPrincipal =
        new GenericPrincipal("my-principal", "my-password", List.of());

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/55976625-31a0-46ed-bee0-d9ba60c784f6 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

hazendaz · 2026-05-17T21:09:52Z

@copilot Lets continue as more found after the initial ones you updated. See Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security5\src\test\java\waffle\spring\DelegatingNegotiateSecurityFilterTest.java:118: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security5\src\test\java\waffle\spring\NegotiateSecurityFilterTest.java:147: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security5\src\test\java\waffle\spring\WindowsAuthenticationProviderTest.java:100: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security5\src\test\java\waffle\spring\WindowsAuthenticationProviderTest.java:131: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security5\src\test\java\waffle\spring\WindowsAuthenticationTokenTest.java:62: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security5\src\test\java\waffle\spring\WindowsAuthenticationTokenTest.java:89: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.4.0:modernizer (modernizer) on project waffle-spring-security5: Found 6 violations -> [Help 1]

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/d7a92697-cd3b-434f-8691-cbf046a39019 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-17T21:13:54Z

@copilot Lets continue as more found after the initial ones you updated. See Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security5\src\test\java\waffle\spring\DelegatingNegotiateSecurityFilte...

Updated all 6 reported waffle-spring-security5 modernizer violations by replacing Collections.sort(list) with list.sort(Comparator.naturalOrder()) and adjusting imports accordingly. Addressed in commit d4c6f5a.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-spring-security5 -am -DskipTests test-compile modernizer:modernizer (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

hazendaz · 2026-05-18T00:31:27Z

@copilot Please also fix D:\a\waffle\waffle\Source\JNA\waffle-tomcat10\src\test\java\waffle\apache\MixedAuthenticatorTest.java:355: Prefer java.util.List.of(). Since this hit tomcat 10, its likely in the other tomcat modules too so maybe best to look for similar pattern throughout.

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/672aa47a-e185-45d5-8891-7c699f1dc91c Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-18T00:37:07Z

@copilot Please also fix D:\a\waffle\waffle\Source\JNA\waffle-tomcat10\src\test\java\waffle\apache\MixedAuthenticatorTest.java:355: Prefer java.util.List.of(). Since this hit tomcat 10, its likely in...

Applied the fix in both Tomcat 10 and Tomcat 11 MixedAuthenticatorTest files, replacing Collections.emptyList() with List.of(), and verified no remaining Collections.emptyList() usages across Tomcat modules. Addressed in commit 72aeb1d. No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-tomcat10,waffle-tomcat11 -am -DskipTests test-compile modernizer:modernizer (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

hazendaz · 2026-05-18T01:38:12Z

@copilot Here are next set of issues

Error: Medium: To make log readable, log format () should contain non-sign character. [waffle.spring.DelegatingNegotiateSecurityFilter] At DelegatingNegotiateSecurityFilter.java:[line 140] SLF4J_SIGN_ONLY_FORMAT
Error: Medium: To make log readable, log format () should contain non-sign character. [waffle.spring.DelegatingNegotiateSecurityFilter] At DelegatingNegotiateSecurityFilter.java:[line 186] SLF4J_SIGN_ONLY_FORMAT
Error: Medium: To make log readable, log format () should contain non-sign character. [waffle.spring.DelegatingNegotiateSecurityFilter] At DelegatingNegotiateSecurityFilter.java:[line 190] SLF4J_SIGN_ONLY_FORMAT
Error: Medium: To make log readable, log format () should contain non-sign character. [waffle.spring.DelegatingNegotiateSecurityFilter] At DelegatingNegotiateSecurityFilter.java:[line 215] SLF4J_SIGN_ONLY_FORMAT
Error: Medium: To make log readable, log format () should contain non-sign character. [waffle.spring.DelegatingNegotiateSecurityFilter] At DelegatingNegotiateSecurityFilter.java:[line 219] SLF4J_SIGN_ONLY_FORMAT
Error: Medium: Method waffle.spring.DelegatingNegotiateSecurityFilterTest.testNegotiate() does not presize the allocation of a collection [waffle.spring.DelegatingNegotiateSecurityFilterTest] At DelegatingNegotiateSecurityFilterTest.java:[line 116] PSC_PRESIZE_COLLECTIONS
Error: High: Method waffle.spring.ImpersonateTest.testImpersonateDisabled() appears to call the same method on the same object redundantly [waffle.spring.ImpersonateTest] At ImpersonateTest.java:[line 161] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
Error: High: Method waffle.spring.ImpersonateTest.testImpersonateEnabled() appears to call the same method on the same object redundantly [waffle.spring.ImpersonateTest] At ImpersonateTest.java:[line 120] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
Error: High: Unconstrained method waffle.spring.NegotiateSecurityFilter.sendUnauthorized(HttpServletResponse, boolean) converts checked exception to unchecked [waffle.spring.NegotiateSecurityFilter] At NegotiateSecurityFilter.java:[line 194] EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS
Error: Medium: To make log readable, log format () should contain non-sign character. [waffle.spring.NegotiateSecurityFilter] At NegotiateSecurityFilter.java:[line 97] SLF4J_SIGN_ONLY_FORMAT
Error: Medium: Method waffle.spring.NegotiateSecurityFilterEntryPointTest.testChallengeGET() accesses list or array with constant index [waffle.spring.NegotiateSecurityFilterEntryPointTest] At NegotiateSecurityFilterEntryPointTest.java:[line 70] CLI_CONSTANT_LIST_INDEX
Error: Medium: Method waffle.spring.NegotiateSecurityFilterEntryPointTest.testChallengeGET() accesses list or array with constant index [waffle.spring.NegotiateSecurityFilterEntryPointTest] At NegotiateSecurityFilterEntryPointTest.java:[line 71] CLI_CONSTANT_LIST_INDEX
Error: Medium: Method waffle.spring.NegotiateSecurityFilterTest.testNegotiate() does not presize the allocation of a collection [waffle.spring.NegotiateSecurityFilterTest] At NegotiateSecurityFilterTest.java:[line 145] PSC_PRESIZE_COLLECTIONS
Error: Medium: Method waffle.spring.WindowsAuthenticationProviderTest.testAuthenticate() does not presize the allocation of a collection [waffle.spring.WindowsAuthenticationProviderTest] At WindowsAuthenticationProviderTest.java:[line 98] PSC_PRESIZE_COLLECTIONS
Error: Medium: Method waffle.spring.WindowsAuthenticationProviderTest.testAuthenticateWithCustomGrantedAuthorityFactory() does not presize the allocation of a collection [waffle.spring.WindowsAuthenticationProviderTest] At WindowsAuthenticationProviderTest.java:[line 129] PSC_PRESIZE_COLLECTIONS
Error: Medium: waffle.spring.WindowsAuthenticationToken.getAuthorities() may expose internal representation by returning WindowsAuthenticationToken.authorities [waffle.spring.WindowsAuthenticationToken] At WindowsAuthenticationToken.java:[line 91] EI_EXPOSE_REP
Error: Medium: Method new waffle.spring.WindowsAuthenticationToken(WindowsPrincipal, GrantedAuthorityFactory, GrantedAuthority) does not presize the allocation of a collection [waffle.spring.WindowsAuthenticationToken] At WindowsAuthenticationToken.java:[line 85] PSC_PRESIZE_COLLECTIONS
Error: Medium: Method waffle.spring.WindowsAuthenticationTokenTest.testCustomGrantedAuthorityFactory() does not presize the allocation of a collection [waffle.spring.WindowsAuthenticationTokenTest] At WindowsAuthenticationTokenTest.java:[line 87] PSC_PRESIZE_COLLECTIONS
Error: Medium: Method waffle.spring.WindowsAuthenticationTokenTest.testWindowsAuthenticationToken() does not presize the allocation of a collection [waffle.spring.WindowsAuthenticationTokenTest] At WindowsAuthenticationTokenTest.java:[line 60] PSC_PRESIZE_COLLECTIONS
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security6\src\test\java\waffle\spring\DelegatingNegotiateSecurityFilterTest.java:118: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security6\src\test\java\waffle\spring\NegotiateSecurityFilterTest.java:147: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security6\src\test\java\waffle\spring\WindowsAuthenticationProviderTest.java:100: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security6\src\test\java\waffle\spring\WindowsAuthenticationProviderTest.java:131: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security6\src\test\java\waffle\spring\WindowsAuthenticationTokenTest.java:62: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security6\src\test\java\waffle\spring\WindowsAuthenticationTokenTest.java:89: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.4.0:modernizer (modernizer) on project waffle-spring-security6: Found 6 violations -> [Help 1]

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/aa355aeb-1cc0-4672-8494-4cdfe4e67541 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-18T01:45:13Z

@copilot Here are next set of issues

Error: Medium: To make log readable, log format () should contain non-sign character. [waffle.spring.DelegatingNegotiateSecurityFilter] At DelegatingNegotiateS...

Applied the waffle-spring-security6 modernizer fixes from this batch by replacing all six Collections.sort(list) usages with list.sort(Comparator.naturalOrder()) in the referenced tests. Addressed in commit 87e01e4. No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-spring-security6 -am -DskipTests verify (dns block)
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-spring-security6 -am -DskipTests install (dns block)
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-spring-security6 -Dtest=DelegatingNegotiateSecurityFilterTest,NegotiateSecurityFilterTest,WindowsAuthenticationProviderTest,WindowsAuthenticationTokenTest -Dsurefire.failIfNoSpecifiedTests=false test D D ED MED UNNAMED D (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

hazendaz · 2026-05-18T02:01:55Z

@copilot Next one to modernize

D:\a\waffle\waffle\Source\JNA\waffle-demo-jakarta\waffle-demo-spring-boot-filter3\src\main\java\waffle\spring\boot\demo\DemoController.java:32: Prefer java.lang.String.formatted(Object...)
Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.4.0:modernizer (modernizer) on project waffle-demo-spring-boot-filter3: Found 1 violations -> [Help 1]

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/3b743252-2e7c-4072-9ed7-bbe3bdb2400c Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-18T02:09:41Z

@copilot Next one to modernize

D:\a\waffle\waffle\Source\JNA\waffle-demo-jakarta\waffle-demo-spring-boot-filter3\src\main\java\waffle\spring\boot\demo\DemoController.java:32: Prefer java.lang.Stri...

Applied the modernization in DemoController by replacing String.format(...) with String.formatted(...). Addressed in commit a4ba803. No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-demo-jakarta/waffle-demo-spring-boot-filter3 -am -DskipTests verify (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

hazendaz · 2026-05-24T16:59:02Z

@copilot Please also update these modernization issues 67
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security7\src\test\java\waffle\spring\DelegatingNegotiateSecurityFilterTest.java:118: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security7\src\test\java\waffle\spring\NegotiateSecurityFilterTest.java:147: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security7\src\test\java\waffle\spring\WindowsAuthenticationProviderTest.java:100: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security7\src\test\java\waffle\spring\WindowsAuthenticationProviderTest.java:131: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security7\src\test\java\waffle\spring\WindowsAuthenticationTokenTest.java:62: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: D:\a\waffle\waffle\Source\JNA\waffle-spring-security7\src\test\java\waffle\spring\WindowsAuthenticationTokenTest.java:89: Prefer java.util.List.sort(Comparator.naturalOrder())
Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.4.0:modernizer (modernizer) on project waffle-spring-security7: Found 6 violations -> [Help 1]

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/94a08263-afe8-4eb2-9e83-10faf5871464 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-24T17:05:57Z

@copilot Please also update these modernization issues 67
Error: D:\a\waffle\waffle\Source\JNA\waffle...

Updated all 6 waffle-spring-security7 modernizer violations by replacing Collections.sort(list) with list.sort(Comparator.naturalOrder()) in the referenced tests. Addressed in commit 9d30bbd. No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-spring-security7 -am -DskipTests verify (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

hazendaz · 2026-05-24T17:22:23Z

@copilot Also fix Error: D:\a\waffle\waffle\Source\JNA\waffle-demo-jakarta\waffle-demo-spring-boot-filter4\src\main\java\waffle\spring\boot\demo\DemoController.java:32: Prefer java.lang.String.formatted(Object...)

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/48d6eead-a29e-43f8-9ac6-26c3277c7c4e Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-24T17:28:51Z

@copilot Also fix Error: D:\a\waffle\waffle\Source\JNA\waffle-demo-jakarta\waffle-demo-spring-boot-filter4\src\main\java\waffle\spring\boot\demo\DemoController.java:32: Prefer java.lang.String.format...

Fixed in waffle-demo-spring-boot-filter4 by replacing String.format(...) with "...".formatted(...) in DemoController. Addressed in commit 06ac8b8. No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-demo-jakarta/waffle-demo-spring-boot-filter4 -am -DskipTests verify (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

hazendaz · 2026-05-24T17:57:03Z

@copilot PLease fix this too D:\a\waffle\waffle\Source\JNA\waffle-shiro\src\test\java\waffle\shiro\GroupMappingWaffleRealmTest.java:49: Prefer java.util.Map.of(Object, Object)
Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.4.0:modernizer (modernizer) on project waffle-shiro: Found 1 violations -> [Help 1]
Error:

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/e1e6b307-2fc4-426c-99dd-05ef9a8447b2 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-24T18:01:57Z

@copilot PLease fix this too D:\a\waffle\waffle\Source\JNA\waffle-shiro\src\test\java\waffle\shiro\GroupMappingWaffleRealmTest.java:49: Prefer java.util.Map.of(Object, Object)
Error: Failed to exe...

Fixed in waffle-shiro by replacing Collections.singletonMap(...) with Map.of(...) in GroupMappingWaffleRealmTest. Addressed in commit 8f25110. No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-shiro -am -DskipTests verify (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

hazendaz · 2026-05-24T19:03:55Z

@copilot Also fix D:\a\waffle\waffle\Source\JNA\waffle-shiro-jakarta\src\test\java\waffle\shiro\GroupMappingWaffleRealmTest.java:49: Prefer java.util.Map.of(Object, Object)
Error: Failed to execute goal org.gaul:modernizer-maven-plugin:3.4.0:modernizer (modernizer) on project waffle-shiro-jakarta: Found 1 violations -> [Help 1]

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/20d0dbb5-d103-4da4-8cb9-752e2ee6d444 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot · 2026-05-24T19:12:25Z

@copilot Also fix D:\a\waffle\waffle\Source\JNA\waffle-shiro-jakarta\src\test\java\waffle\shiro\GroupMappingWaffleRealmTest.java:49: Prefer java.util.Map.of(Object, Object)
Error: Failed to execute ...

Fixed in waffle-shiro-jakarta by replacing Collections.singletonMap(...) with Map.of(...) in GroupMappingWaffleRealmTest. Addressed in commit a45d792. No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/waffle/waffle/Source/JNA org.codehaus.plexus.classworlds.launcher.Launcher -pl waffle-shiro-jakarta -am -DskipTests verify (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

coveralls · 2026-05-24T19:28:58Z

Coverage is 66.667% — copilot/modernize-mixed-authenticator-test into master. No base build found for master.

Copilot AI and others added 2 commits May 17, 2026 20:47

Modernize empty list creation in MixedAuthenticatorTest

d98ad6a

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/55976625-31a0-46ed-bee0-d9ba60c784f6 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Finalize modernizer fix validation

d0de477

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/55976625-31a0-46ed-bee0-d9ba60c784f6 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot AI assigned Copilot and hazendaz May 17, 2026

Copilot created this pull request from a session on behalf of hazendaz May 17, 2026 21:04 View session

hazendaz approved these changes May 17, 2026

View reviewed changes

Copilot started work on behalf of hazendaz May 17, 2026 21:10 View session

Modernize spring-security5 tests to use List.sort natural order

d4c6f5a

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/d7a92697-cd3b-434f-8691-cbf046a39019 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 17, 2026 21:14

Copilot AI requested a review from hazendaz May 17, 2026 21:14

Copilot started work on behalf of hazendaz May 18, 2026 00:34 View session

Modernize tomcat10 and tomcat11 MixedAuthenticatorTest empty lists

72aeb1d

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/672aa47a-e185-45d5-8891-7c699f1dc91c Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 18, 2026 00:37

Copilot started work on behalf of hazendaz May 18, 2026 01:38 View session

Modernize spring-security6 tests to List.sort natural order

87e01e4

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/aa355aeb-1cc0-4672-8494-4cdfe4e67541 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 18, 2026 01:46

Copilot started work on behalf of hazendaz May 18, 2026 02:02 View session

Modernize demo controller to String.formatted

a4ba803

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/3b743252-2e7c-4072-9ed7-bbe3bdb2400c Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 18, 2026 02:10

Copilot started work on behalf of hazendaz May 24, 2026 16:59 View session

Modernize spring-security7 test list sorting

9d30bbd

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/94a08263-afe8-4eb2-9e83-10faf5871464 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 24, 2026 17:06

Copilot started work on behalf of hazendaz May 24, 2026 17:22 View session

Modernize filter4 DemoController string formatting

06ac8b8

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/48d6eead-a29e-43f8-9ac6-26c3277c7c4e Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 24, 2026 17:29

Copilot started work on behalf of hazendaz May 24, 2026 17:57 View session

Modernize shiro group map setup

8f25110

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/e1e6b307-2fc4-426c-99dd-05ef9a8447b2 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 24, 2026 18:02

Copilot started work on behalf of hazendaz May 24, 2026 19:04 View session

Modernize shiro-jakarta group map setup

a45d792

Agent-Logs-Url: https://github.com/Waffle/waffle/sessions/20d0dbb5-d103-4da4-8cb9-752e2ee6d444 Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Copilot finished work on behalf of hazendaz May 24, 2026 19:13

hazendaz approved these changes May 24, 2026

View reviewed changes

hazendaz marked this pull request as ready for review May 24, 2026 19:29

hazendaz merged commit dceec15 into master May 24, 2026
18 of 19 checks passed

Uh oh!

Conversation

Copilot AI commented May 17, 2026

Uh oh!

hazendaz commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

hazendaz commented May 18, 2026

Uh oh!

Copilot AI commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

hazendaz commented May 18, 2026

Uh oh!

Copilot AI commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

hazendaz commented May 18, 2026

Uh oh!

Copilot AI commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

hazendaz commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

hazendaz commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

hazendaz commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

hazendaz commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

coveralls commented May 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 17, 2026 •

edited

Loading

Copilot AI commented May 18, 2026 •

edited

Loading

Copilot AI commented May 18, 2026 •

edited

Loading

Copilot AI commented May 18, 2026 •

edited

Loading

Copilot AI commented May 24, 2026 •

edited

Loading

Copilot AI commented May 24, 2026 •

edited

Loading

Copilot AI commented May 24, 2026 •

edited

Loading

Copilot AI commented May 24, 2026 •

edited

Loading