Simplify show changes tool schema#51
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughSimplifies the Changesshow_changes contract simplification
Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)sequenceDiagram
participant Model
participant MCPServer
participant ReviewCheckpoints
Model->>MCPServer: call show_changes(workspaceId)
MCPServer->>ReviewCheckpoints: reviewChanges(since: "last_shown", markReviewed: true)
ReviewCheckpoints-->>MCPServer: aggregate diff since last checkpoint
MCPServer-->>Model: rendered diff, checkpoint advanced
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
9e16b35 to
14786d9
Compare
There was a problem hiding this comment.
Pull request overview
This PR simplifies the model-facing show_changes tool interface by removing optional inputs and standardizing checkpoint behavior inside DevSpace, and it adds documentation plus example “agent profile” templates to illustrate the emerging profile format.
Changes:
- Remove model-facing
since/markReviewedinputs from theshow_changesMCP tool and always compare againstlast_shownwhile marking reviewed. - Document the minimal end-of-turn
show_changesworkflow. - Add and ship example local-agent profile templates (
examples/agents) plus a draft schema document.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server.ts | Simplifies show_changes tool schema and hard-codes checkpoint behavior to last_shown + mark reviewed. |
| package.json | Publishes the new examples/ directory in the npm package. |
| examples/agents/README.md | Adds guidance for the agent-profile examples directory. |
| examples/agents/pi-reviewer.md | Adds a read-only “pi” reviewer profile template. |
| examples/agents/opencode-explorer.md | Adds a read-only “opencode” explorer profile template. |
| examples/agents/cursor-agent-worker.md | Adds a writable “cursor” worker profile template. |
| examples/agents/copilot-reviewer.md | Adds a read-only “copilot” reviewer profile template. |
| examples/agents/codex-worker.md | Adds a writable “codex” worker profile template. |
| examples/agents/codex-explorer.md | Adds a read-only “codex” explorer profile template. |
| examples/agents/claude-implementer.md | Adds a writable “claude” implementer profile template. |
| docs/chatgpt-coding-workflow.md | Documents the simplified show_changes end-of-turn calling convention and checkpoint behavior. |
| docs/agent-profile-schema.md | Introduces a draft “agent profile” schema and conventions for the example templates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/agents/README.md`:
- Line 14: The README’s schema link points to a non-repo-relative path, so
update the reference in the agents README to use a repo-relative link from
`examples/agents/README.md` to the draft schema. Make sure the link resolves
correctly when viewed from that directory, and if this README is included in the
npm tarball, verify the target doc is published there or point the link at a
shipped location instead.
In `@src/server.ts`:
- Around line 1165-1176: The show_changes tool is incorrectly marked as
read-only even though the reviewChanges call uses markReviewed: true and mutates
the review baseline. In the tool descriptor in src/server.ts where
toolWidgetDescriptorMeta(config, "show_changes") is defined, remove the
annotations.readOnlyHint flag so the tool is treated as state-changing and won’t
be auto-run by clients.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2fdff6a0-20d1-43b3-a89b-eb6e406f3500
📒 Files selected for processing (12)
docs/agent-profile-schema.mddocs/chatgpt-coding-workflow.mdexamples/agents/README.mdexamples/agents/claude-implementer.mdexamples/agents/codex-explorer.mdexamples/agents/codex-worker.mdexamples/agents/copilot-reviewer.mdexamples/agents/cursor-agent-worker.mdexamples/agents/opencode-explorer.mdexamples/agents/pi-reviewer.mdpackage.jsonsrc/server.ts
Summary
sinceandmarkReviewedinputs fromshow_changeslast_shownand marking the diff reviewedTesting
npm run typechecknpm testSummary by CodeRabbit
Documentation
Bug Fixes