Skip to content

fix: add missing AppAttestProviderFactory implementation#64

Merged
Njones27 merged 1 commit intomainfrom
fix/app-attest-provider-factory
Apr 17, 2026
Merged

fix: add missing AppAttestProviderFactory implementation#64
Njones27 merged 1 commit intomainfrom
fix/app-attest-provider-factory

Conversation

@Njones27
Copy link
Copy Markdown
Collaborator

Summary

Fixes the release build failure after PR #63. The Firebase iOS SDK provides AppAttestProvider but does not ship a factory class for it — only AppCheckDebugProviderFactory is built in. The release-build call to AppAttestProviderFactory() failed to compile with:

Cannot find 'AppAttestProviderFactory' in scope

This PR adds a small custom factory conforming to AppCheckProviderFactory that returns an AppAttestProvider, matching the pattern Firebase recommends for iOS 14+ App Attest integration.

Change

A 7-line addition to WalkWorthyApp.swift:

final class AppAttestProviderFactory: NSObject, AppCheckProviderFactory {
    func createProvider(with app: FirebaseApp) -> AppCheckProvider? {
        return AppAttestProvider(app: app)
    }
}

Test plan

  • Build Archive succeeds in Xcode Cloud / local archive
  • Debug build still works (uses AppCheckDebugProviderFactory)
  • Release build uses App Attest

🤖 Generated with Claude Code

The Firebase iOS SDK ships AppAttestProvider but not a factory class for it
(only AppCheckDebugProviderFactory is built-in). The release-build call to
AppAttestProviderFactory() failed to compile with "Cannot find
'AppAttestProviderFactory' in scope". This adds a small custom factory that
returns an AppAttestProvider, matching the pattern Firebase recommends.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Njones27 Njones27 merged commit b87eaf0 into main Apr 17, 2026
1 check passed
@Njones27 Njones27 deleted the fix/app-attest-provider-factory branch April 17, 2026 05:20
@Njones27
Copy link
Copy Markdown
Collaborator Author

hot fix, we push without checks because I'm awesome

@Njones27 Njones27 self-assigned this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant