fix: add missing AppAttestProviderFactory implementation#64
Merged
Conversation
The Firebase iOS SDK ships AppAttestProvider but not a factory class for it (only AppCheckDebugProviderFactory is built-in). The release-build call to AppAttestProviderFactory() failed to compile with "Cannot find 'AppAttestProviderFactory' in scope". This adds a small custom factory that returns an AppAttestProvider, matching the pattern Firebase recommends. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
hot fix, we push without checks because I'm awesome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release build failure after PR #63. The Firebase iOS SDK provides
AppAttestProviderbut does not ship a factory class for it — onlyAppCheckDebugProviderFactoryis built in. The release-build call toAppAttestProviderFactory()failed to compile with:This PR adds a small custom factory conforming to
AppCheckProviderFactorythat returns anAppAttestProvider, matching the pattern Firebase recommends for iOS 14+ App Attest integration.Change
A 7-line addition to
WalkWorthyApp.swift:Test plan
Build Archivesucceeds in Xcode Cloud / local archiveAppCheckDebugProviderFactory)🤖 Generated with Claude Code