This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Bug fix, null pointer on missing methods#20
Closed
dmdeklerk wants to merge 3 commits intoWalletConnect:masterfrom
Closed
Bug fix, null pointer on missing methods#20dmdeklerk wants to merge 3 commits intoWalletConnect:masterfrom
dmdeklerk wants to merge 3 commits intoWalletConnect:masterfrom
Conversation
Contributor
|
If this only fixed the null pointer with methods I would accept it, but it also has 2 other changes that don't have anything to do with it. If you'd like for it to be merged, removed the ? in optionalNamespaces and the jsonRpcRelay event broadcast. |
Contributor
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19
Resolves # 19
#19