Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

use a new statement#63

Merged
devceline merged 20 commits intomainfrom
chore/update-statements-oct-12
Oct 18, 2023
Merged

use a new statement#63
devceline merged 20 commits intomainfrom
chore/update-statements-oct-12

Conversation

@devceline
Copy link
Copy Markdown
Contributor

@devceline devceline commented Oct 12, 2023 •
edited
Loading

Changes

@devceline devceline marked this pull request as ready for review October 13, 2023 12:01
bkrem
bkrem approved these changes Oct 13, 2023
View reviewed changes
Comment thread packages/notify-client/src/controllers/engine.ts Outdated
Comment thread packages/notify-client/test/clients.spec.ts Outdated
devceline and others added 8 commits October 13, 2023 14:17
@devceline @bkrem
Update packages/notify-client/src/controllers/engine.ts
6f93280 
Co-authored-by: Ben Kremer <ben@walletconnect.com>
@devceline @bkrem
Update packages/notify-client/test/clients.spec.ts
5d267aa 
Co-authored-by: Ben Kremer <ben@walletconnect.com>
@devceline @bkrem
feat: use explorer api for config (#62)
2065e7e 
* feat: use explorer api for config

* chore: use correct notification id for unit test

* release: release canary for testing

* Update packages/notify-client/src/controllers/engine.ts

Co-authored-by: Ben Kremer <ben@walletconnect.com>

* fix: incorrect type

* chore: run prettier

* chore(release): release canary for testing

---------

Co-authored-by: Ben Kremer <ben@walletconnect.com>
@devceline
chore: update package version for release
5db7570
@devceline
fix: UT failing due to flag being reset
424117b
@devceline
chore: prep canary release
cca431e
@devceline
chore: update scope map external type
bb22c8c
@devceline
chore: prep canary bb22c8c
85a04ae
@devceline
Copy link
Copy Markdown
Contributor Author

devceline commented Oct 16, 2023

Resolves #61

@devceline devceline linked an issue Oct 16, 2023 that may be closed by this pull request
Use cloud for fetching wc-notify-config #61
Closed
@devceline devceline requested a review from bkrem October 16, 2023 12:52
bkrem
bkrem approved these changes Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Spec should be merged though before we release this on latest based on company due diligence with specs.

Comment thread packages/notify-client/test/helpers/notify.ts
bkrem
bkrem reviewed Oct 16, 2023
View reviewed changes
Comment thread packages/notify-client/test/helpers/notify.ts Outdated
@devceline devceline merged commit 185804c into main Oct 18, 2023
@devceline devceline deleted the chore/update-statements-oct-12 branch October 18, 2023 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bkrem bkrem bkrem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use cloud for fetching wc-notify-config

2 participants

@devceline @bkrem