Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

hotfix: update icons to spec#64

Merged
devceline merged 3 commits intomainfrom
fix/update-icon-type-to-spec
Oct 18, 2023
Merged

hotfix: update icons to spec#64
devceline merged 3 commits intomainfrom
fix/update-icon-type-to-spec

Conversation

@devceline
Copy link
Copy Markdown
Contributor

@devceline devceline commented Oct 18, 2023

  • revert change where icons where made to be a Record<string, string>
  • map icons coming from explorer to icon string array

this was an oversight in the previous PR, as I assumed the specs were changing accordingly.

@devceline devceline marked this pull request as ready for review October 18, 2023 14:12
@devceline devceline requested a review from bkrem October 18, 2023 14:16
@devceline devceline changed the title fix: update icons to spec hotfix: update icons to spec Oct 18, 2023
@devceline devceline merged commit 257abe3 into main Oct 18, 2023
@devceline devceline deleted the fix/update-icon-type-to-spec branch October 18, 2023 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants