Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Refactor/use new register method#82

Merged
devceline merged 18 commits intomainfrom
refactor/use-new-register-method
Dec 19, 2023
Merged

Refactor/use new register method#82
devceline merged 18 commits intomainfrom
refactor/use-new-register-method

Conversation

@devceline
Copy link
Copy Markdown
Contributor

@devceline devceline commented Dec 7, 2023

Note

All required PRs have been merged.

Changes

Per new spec updates here, here , here, and identity util changes here, the notify client registration methodology is as follows:

  • register is now split into two functions :
    • prepareRegistration: Actually prepare the registration
    • register: Use the prepared registration, as well as a signature of the message from prepped registration, to actually register the identity.
  • Addition of new function isRegistered to check registration status.
  • Update checkStatementIsStale to checkRegistrationIsStale since it now also checks against domain.

Implications of this

  • Register now no longer automatically unregisters accounts that have stale statements. That logic is now handled by the user of the client, via checking isRegistered.
  • UIs (I.E Web3Inbox) will have to refactor how they handle signatures completely

Tested

Tested via updating existing unit tests to use new API.

Notes

@devceline devceline marked this pull request as ready for review December 18, 2023 09:14
@devceline devceline requested a review from bkrem December 18, 2023 09:14
Copy link
Copy Markdown
Contributor

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

Great PR description here 🔥

signature,
});

const allApps =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of this boolean naming but I see it's been agreed in the spec for the parameter further up so fine with keeping this consistent

@devceline devceline merged commit a816560 into main Dec 19, 2023
@devceline devceline deleted the refactor/use-new-register-method branch December 19, 2023 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants