This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Merged
Conversation
it was generating the opposite statement
bkrem
approved these changes
Dec 18, 2023
| signature, | ||
| }); | ||
|
|
||
| const allApps = |
Contributor
There was a problem hiding this comment.
Not a huge fan of this boolean naming but I see it's been agreed in the spec for the parameter further up so fine with keeping this consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
All required PRs have been merged.
Changes
Per new spec updates here, here , here, and identity util changes here, the notify client registration methodology is as follows:
registeris now split into two functions :prepareRegistration: Actually prepare the registrationregister: Use the prepared registration, as well as a signature of the message from prepped registration, to actually register the identity.isRegisteredto check registration status.checkStatementIsStaletocheckRegistrationIsStalesince it now also checks against domain.Implications of this
isRegistered.Tested
Tested via updating existing unit tests to use new API.
Notes
Won't merge until MakeisRegisteredtake same params asprepareRegistrationto check registration status accurately walletconnect-specs#181 is merged1.0.1is currenty a canary, will go to stable once this is merged.