Skip to content

[rpc] fix: classify zero visible GPUs as unavailable#317

Merged
Wangmerlyn merged 1 commit into
mainfrom
codex/no-visible-startup-unavailable
Jul 2, 2026
Merged

[rpc] fix: classify zero visible GPUs as unavailable#317
Wangmerlyn merged 1 commit into
mainfrom
codex/no-visible-startup-unavailable

Conversation

@Wangmerlyn

Copy link
Copy Markdown
Owner

Summary

  • Classify startup attempts with zero visible Torch-addressable GPUs as startup-unavailable before explicit GPU ordinal validation.
  • Preserve invalid-params behavior for explicit GPU IDs outside a non-empty visible set.
  • Update MCP/service docs and AGENTS.md to record the zero-visible vs out-of-range contract.

Verification

  • PYTHONPATH=src:. pytest -q tests/test_cli_service_commands.py tests/mcp/test_server.py tests/global_controller/global_keep_test.py tests/test_package_metadata.py

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wangmerlyn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 84cb2607-803b-4c42-8895-2bb68bac1f0e

📥 Commits

Reviewing files that changed from the base of the PR and between a99bd49 and f5fd457.

📒 Files selected for processing (4)
  • AGENTS.md
  • docs/guides/mcp.md
  • src/keep_gpu/global_gpu_controller/global_gpu_controller.py
  • tests/mcp/test_server.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/no-visible-startup-unavailable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the system behavior when there are zero visible GPU devices, ensuring that starting a keep worker with explicit GPU IDs results in a startup unavailable error (JSON-RPC code -32000). This behavior is documented in AGENTS.md and docs/guides/mcp.md, implemented in global_gpu_controller.py by raising a NoGPUAvailableError when the visible device count is zero or less, and verified via a new unit test in test_server.py. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Wangmerlyn Wangmerlyn merged commit d239ec2 into main Jul 2, 2026
6 checks passed
@Wangmerlyn Wangmerlyn deleted the codex/no-visible-startup-unavailable branch July 2, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant