Skip to content

fix: remove invalid specialization for uint128#4796

Merged
q82419 merged 1 commit into
masterfrom
hydai/fix_llvm_libcpp_issue
Apr 17, 2026
Merged

fix: remove invalid specialization for uint128#4796
q82419 merged 1 commit into
masterfrom
hydai/fix_llvm_libcpp_issue

Conversation

@hydai
Copy link
Copy Markdown
Member

@hydai hydai commented Apr 15, 2026

Description

Fixes #4071

Checklist

Before submitting this PR, please ensure the following:

  • DCO Signed-off: All commits are signed-off (git commit -s). CI workflows will only be approved if DCO check is passed.
  • Commit Messages: Run commitlint on your commit messages to ensure they meet the Conventional Commit standards.
  • Local Tests Passed: Provide a screenshot or logs below to prove that you have passed the test suites locally.

Test Evidence


Important: This PR will be automatically closed if the above requirements are not met.

Tip: If you want to run CI jobs on GitHub, you can create a PR to your own forked repository to trigger the workflows.

Signed-off-by: hydai <z54981220@gmail.com>
@github-project-automation github-project-automation Bot moved this to Triage-required in WasmEdge Roadmap Apr 15, 2026
@github-actions github-actions Bot added c-CI An issue related to CI c-Common labels Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.44%. Comparing base (240c6ac) to head (4b24320).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4796      +/-   ##
==========================================
- Coverage   81.45%   81.44%   -0.01%     
==========================================
  Files         301      301              
  Lines       42263    42264       +1     
  Branches     7011     7012       +1     
==========================================
- Hits        34425    34424       -1     
- Misses       5882     5883       +1     
- Partials     1956     1957       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

q82419
q82419 previously approved these changes Apr 16, 2026
@hydai hydai marked this pull request as ready for review April 16, 2026 10:48
@hydai hydai requested review from 0yi0 and ibmibmibm as code owners April 16, 2026 10:48
@hydai hydai force-pushed the hydai/fix_llvm_libcpp_issue branch from 4b24320 to aa0d621 Compare April 16, 2026 10:49
@hydai
Copy link
Copy Markdown
Member Author

hydai commented Apr 16, 2026

@q82419 I just removed the temporary commit for verification on macOS 26. PTAL

@github-actions github-actions Bot removed the c-CI An issue related to CI label Apr 16, 2026
@q82419 q82419 merged commit 40ca5d8 into master Apr 17, 2026
70 of 73 checks passed
@q82419 q82419 deleted the hydai/fix_llvm_libcpp_issue branch April 17, 2026 03:32
@github-project-automation github-project-automation Bot moved this from Triage-required to Done in WasmEdge Roadmap Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bug: fails to build with LLVM libc++

2 participants