Skip to content

Add AR Scan Eligible #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TurtIeSocks merged 8 commits into from
Jan 16, 2021
Merged

Add AR Scan Eligible #281

TurtIeSocks merged 8 commits into from
Jan 16, 2021

Conversation

@LordJavi
Copy link
Contributor

@LordJavi LordJavi commented Nov 21, 2020 •
edited
Loading

⚠️ RequiresRDM backend RealDeviceMap/RealDeviceMap#186

@versx versx added the enhancement New feature or request label Nov 23, 2020
versx
versx approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@versx versx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pretty helpful.

Mygod
Mygod previously requested changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@Mygod Mygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not support for gym?

@TurtIeSocks
Copy link
Contributor

TurtIeSocks commented Nov 28, 2020 •
edited
Loading

Chuck #18 should now support this PR for testing. For both gyms and stops.

TurtIeSocks
TurtIeSocks requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@TurtIeSocks TurtIeSocks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this configurable since it's probably going to be a little bit before the RDM PR is merged and I don't want to break mapjs for everyone who isn't running RDM vanilla these days.

Add to default.json in the db.scanner section:
"arScanColumn": false

Add to map.js right above the let sql = in this pr:
const ar_scan_eligible = config.db.scanner.arScanColumn ? ', ar_scan_eligible' : '';

And the below suggestion.

Thoughts?

@LordJavi LordJavi requested review from Mygod and TurtIeSocks January 8, 2021 09:39
@LordJavi LordJavi requested a review from versx January 8, 2021 09:49
TurtIeSocks
TurtIeSocks requested changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to remove 2 spaces in the backend and add an icon for an eligible gym and this will be ready.

LordJavi and others added 2 commits January 16, 2021 11:11
@LordJavi @TurtIeSocks
Apply suggestions from code review
ec54fcf 
Co-authored-by: TurtIeSocks <58572875+TurtIeSocks@users.noreply.github.com>
@LordJavi
Update index.js
397a4ff
@LordJavi LordJavi requested a review from TurtIeSocks January 16, 2021 10:19
@TurtIeSocks TurtIeSocks merged commit 1cf4bb8 into WatWowMap:master Jan 16, 2021
@LordJavi LordJavi deleted the ar-scan-eligible branch May 12, 2021 19:32
@LordJavi LordJavi restored the ar-scan-eligible branch May 12, 2021 19:33
@LordJavi LordJavi deleted the ar-scan-eligible branch May 12, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TurtIeSocks TurtIeSocks TurtIeSocks approved these changes

@Mygod Mygod Awaiting requested review from Mygod

@versx versx Awaiting requested review from versx

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LordJavi @TurtIeSocks @versx @Mygod